HDDS-14659. Add new proto message for lightweight MultipartPartInfo#9867
HDDS-14659. Add new proto message for lightweight MultipartPartInfo#9867devabhishekpal wants to merge 8 commits intoapache:masterfrom
Conversation
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @devabhishekpal for the patch.
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
hadoop-ozone/interface-storage/src/main/proto/OmStorageProtocol.proto
Outdated
Show resolved
Hide resolved
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @devabhishekpal for updating the patch, LGTM. Let's wait for others to take a look.
|
@ChenSammi @ivandika3 @errose28 could you take a look at this patch? |
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
| optional uint64 objectID = 7; | ||
| optional uint64 updateID = 8; | ||
| optional FileEncryptionInfoProto fileEncryptionInfo = 9; | ||
| optional FileChecksumProto fileChecksum = 10; |
There was a problem hiding this comment.
Can you check whether "optional string ownerName" is required at part level. For example, any auditing purpose. Earlier, this was stored indirectly through KeyInfo.
There was a problem hiding this comment.
I think per part owner metadata is not required.
This was mostly incidental metadata as enforcement of ACL did not rely on per-part owner. Also I think checks on native authorizer is done on bucket level for listing operations. But maybe key write does open key ACL check for that write.
I think owner metadata and acls can be pulled up to the MultipartInfo message as that is the equivalent of a key. Let me do that.
What changes were proposed in this pull request?
HDDS-14659. Add new proto message for lightweight MutlipartPartInfo
Please describe your PR in detail:
MultipartPartInfo. This contains the absolutely essential fields required for any given part and drops any extra fields.MultipartKeyInfomessage to pull in common metadata fields likevolumeName,bucketName,keyName.schemaVersionwhich will help us with deciding whether to use a new flow for writing MPU parts, or use the currently approach of storing parts inline.Reference design doc: #9793
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14659
How was this patch tested?
Patch was tested via unit tests, but currently this change will not affect any behaviour.