HDDS-14671. Remove healthy_readonly state from SCM by sodonnel · Pull Request #9836 · apache/ozone

sodonnel · 2026-02-26T13:53:47Z

What changes were proposed in this pull request?

Healthy_Readonly was added only for the upgrade flow, and it is no longer needed, so we should remove it.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14671

How was this patch tested?

Existing tests, some of which were modified to reflect the new behavior.

…ne creation

Gargi-jais11

Thanks @sodonnel for the patch.
Few more places it needs updation like comment changes.

hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeStateManager.java

Gargi-jais11 · 2026-02-26T16:15:47Z

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestHDDSUpgrade.java

    // All datanodes on the SCM should have moved to HEALTHY-READONLY state.
-    TestHddsUpgradeUtils.testDataNodesStateOnSCM(
-        cluster.getStorageContainerManagersList(), NUM_DATA_NODES,
-        HEALTHY_READONLY, HEALTHY);
+    TestHddsUpgradeUtils.testDataNodesStateOnSCM(cluster.getStorageContainerManagersList(), NUM_DATA_NODES, HEALTHY);


Please update the comment above to:

All datanodes on the SCM should have moved to HEALTHY state.

Gargi-jais11 · 2026-02-26T16:18:38Z

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java

Please update the comment here as well.

Gargi-jais11 · 2026-02-26T16:19:27Z

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java

Please update this comment as well.

Gargi-jais11 · 2026-02-26T16:30:58Z

I think the Dropdown and query still include "healthy_readonly" in Grafana dashboard of Overall-Metrics. This should be removed since the state is deprecated.

Gargi-jais11 · 2026-02-26T16:39:19Z

In TestSCMNodeMetrics at Line 177 and Line 249 since the metric is deprecated so have you kept it for compatibility checks? Although if the metric remains it is always 0.

sodonnel · 2026-02-26T17:46:10Z

In TestSCMNodeMetrics at Line 177 and Line 249 since the metric is deprecated so have you kept it for compatibility checks? Although if the metric remains it is always 0.

I just didn't know that was there. I have removed the metrics now. It is better to take them away I think.

I have addressed the other comments too.

Gargi-jais11 · 2026-02-26T18:32:29Z

In TestSCMNodeMetrics at Line 177 and Line 249 since the metric is deprecated so have you kept it for compatibility checks? Although if the metric remains it is always 0.

I just didn't know that was there. I have removed the metrics now. It is better to take them away I think.

I have addressed the other comments too.

Thank you. It happens while removing code we don't know about code in few places

Gargi-jais11

I checked the codebase with keyword healthy_readonly no more can be found except for compatibility reasons.
Just in the documentation of NonRolling-upgrades there is mention about Healthy_Readonly state, here https://ozone.apache.org/docs/administrator-guide/operations/upgrade-and-downgrade/#querying-finalization-status

sodonnel · 2026-02-27T17:19:00Z

I create HDDS-14739 to update the website after this one is committed. However we probably need to hold off on doing that, as these changes are going to a branch and they won't be in a release for a while. Until then, the documentation remains valid!

Gargi-jais11 · 2026-02-27T17:39:17Z

I create HDDS-14739 to update the website after this one is committed. However we probably need to hold off on doing that, as these changes are going to a branch and they won't be in a release for a while. Until then, the documentation remains valid!

Makes sense!

Gargi-jais11

LGTM

errose28

Thanks for working on this @sodonnel.

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java

...zone/integration-test/src/test/java/org/apache/hadoop/hdds/upgrade/TestHddsUpgradeUtils.java

hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java

errose28

Thanks for working on this @sodonnel.

…eeded

errose28

I think we can remove the synchronization as discussed here. Other than that this LGTM.

sodonnel · 2026-03-04T12:29:46Z

@errose28 I made the change to take out the comment and synchronization and the CI is green so I went ahead and committed. Thanks for the review @errose28 and @Gargi-jais11!

S O'Donnell added 6 commits February 25, 2026 10:56

Initial changes

0972890

Fix PMD

1e648ac

Fix javadoc compile

8320bc1

Fix failing NodeManager tests related to closing pipelines and pipeli…

d37d427

…ne creation

Fix PMD ... again

0470b3c

and fix checkstyle

7c101e3

sodonnel changed the title ~~HDDS-14671~~ HDDS-14671. Remove healthy_readonly state from SCM Feb 26, 2026

github-actions bot added the zdu Pull requests for Zero Downtime Upgrade (ZDU) https://issues.apache.org/jira/browse/HDDS-14496 label Feb 26, 2026

Additional occurrences of readonly removed

b2a68db

Gargi-jais11 reviewed Feb 26, 2026

View reviewed changes

Address review comments

35f52c4

Fix PMD

37cdd2a

Gargi-jais11 reviewed Feb 27, 2026

View reviewed changes

Gargi-jais11 approved these changes Feb 27, 2026

View reviewed changes

errose28 self-requested a review February 27, 2026 20:01

errose28 reviewed Mar 3, 2026

View reviewed changes

S O'Donnell added 7 commits March 3, 2026 12:08

Merge branch 'HDDS-14496-zdu' into HDDS-14671-healthy-readonly

904ab5a

Remove the LAYOUT_MISMATCH, LAYOUT_MATCH events which are no longer n…

4c76919

…eeded

nit: assertion arg order

782821b

Stale comments in test code

8d4e555

Fix pmd

bb045d5

Fix more PMD

f9577cf

Fix javadoc

61260eb

errose28 reviewed Mar 4, 2026

View reviewed changes

Remove synchronize

c9d953d

sodonnel merged commit c920cd4 into apache:HDDS-14496-zdu Mar 4, 2026
43 checks passed

Conversation

sodonnel commented Feb 26, 2026

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Gargi-jais11 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Gargi-jais11 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Gargi-jais11 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Gargi-jais11 commented Feb 26, 2026

Uh oh!

Gargi-jais11 commented Feb 26, 2026

Uh oh!

sodonnel commented Feb 26, 2026

Uh oh!

Gargi-jais11 commented Feb 26, 2026

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

sodonnel commented Feb 27, 2026

Uh oh!

Gargi-jais11 commented Feb 27, 2026

Uh oh!

Gargi-jais11 left a comment

Choose a reason for hiding this comment

Uh oh!

errose28 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

errose28 left a comment

Choose a reason for hiding this comment

Uh oh!

errose28 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sodonnel commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants