HDDS-14709. Initialize AbstractReplicationTask metrics during start up.#9819
Open
aswinshakil wants to merge 1 commit intoapache:masterfrom
Open
HDDS-14709. Initialize AbstractReplicationTask metrics during start up.#9819aswinshakil wants to merge 1 commit intoapache:masterfrom
aswinshakil wants to merge 1 commit intoapache:masterfrom
Conversation
adoroszlai
reviewed
Mar 4, 2026
Comment on lines
+267
to
+271
| task.getClass().getSimpleName()); | ||
| } | ||
|
|
||
| public void initCounters(String metricName, String metricDescriptionSegment, | ||
| String taskSimpleName) { |
Contributor
There was a problem hiding this comment.
I think it would be better to pass the class itself instead of its name. This would retain previous behavior of not having to call getSimpleName() for each task in the common case that metrics are already initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now the metrics for all
AbstractReplicationTaskis only created only when eachTaskis added to the queue.All the metrics should be initialized to 0 during startup rather than only being added when each Task is added.
What is the link to the Apache JIRA
HDDS-14709
How was this patch tested?
Existing Tests.