Skip to content

MINIFICPP-2728 upgrade openssl to 3.3.6#2115

Closed
szaszm wants to merge 5 commits intoapache:mainfrom
szaszm:MINIFICPP-2728
Closed

MINIFICPP-2728 upgrade openssl to 3.3.6#2115
szaszm wants to merge 5 commits intoapache:mainfrom
szaszm:MINIFICPP-2728

Conversation

@szaszm
Copy link
Member

@szaszm szaszm commented Feb 23, 2026

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we (or do we want to) upgrade the FIPS OpenSSL version, too? 3.1.2 seems to be FIPS-validated now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to, but I can try doing that too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should if it only takes changing the version from 3.0.9 to 3.1.2. If non-trivial changes are needed, we can postpone it to the next release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the change is trivial and builds successfully we should at least run the FIPS variant of the verify package jobs to see if all those tests also pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/szaszm/nifi-minifi-cpp/actions/runs/22370135157
here's a run. Most of the modular docker test jobs fail, but none of the FIPS mode ones. I think the timeouts are just too tight on those jobs with the new modular docker test library.

Copy link
Contributor

@lordgamez lordgamez Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it just occurred to me that the modular tests do not have FIPS mode on the main branch yet, and the HTTPS tests are part of the modular docker tests already. The FIPS mode option for the modular tests was added in #2110 maybe it would be better to run a verify package test run on a separate branch with these commits rebased to that PR (with and without FIPS).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll just revert the version change instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants