Skip to content

fix: resolve SLF4J and Logback compatibility issues #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GOODBOY008 wants to merge 1 commit into
base: main
Choose a base branch
from
+35 −38
Open

fix: resolve SLF4J and Logback compatibility issues #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions fesod-examples/fesod-sheet-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-logging</artifactId>
</exclusion>
<exclusion>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</exclusion>
</exclusions>
</dependency>
<!-- Use Logback 1.2.x with SLF4J 1.7.x for Spring Boot 2.7.x compatibility -->
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states "Use Logback 1.2.x with SLF4J 1.7.x for Spring Boot 2.7.x compatibility" but the parent POM (line 73) now declares slf4j-api version 2.0.17, not 1.7.x. Since this module excludes slf4j-api from spring-boot-starter-web and doesn't explicitly declare its own slf4j-api dependency, it will inherit version 2.0.17 from the parent, making the comment inaccurate. Either update the comment to reflect the actual configuration or add an explicit slf4j-api 1.7.36 dependency to match the comment's intent.

Suggested change
<!-- Use Logback 1.2.x with SLF4J 1.7.x for Spring Boot 2.7.x compatibility -->
<!-- Use Logback 1.2.x; SLF4J version is inherited from the parent POM (currently 2.0.17) -->

Copilot uses AI. Check for mistakes.
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.13</version>
<scope>test</scope>
</dependency>
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module explicitly uses Logback 1.2.13 which requires SLF4J 1.7.x, but the parent POM now defines slf4j-api.version as 2.0.17 (line 73 in parent pom.xml). This creates a version conflict:

  • Logback 1.2.13 depends on SLF4J 1.7.x
  • Parent POM declares SLF4J 2.0.17

Since this module excludes slf4j-api from spring-boot-starter-web (line 52-54) and relies on the parent's SLF4J version, there will be a runtime incompatibility. Either:

  1. Keep Logback 1.2.13 and explicitly declare slf4j-api 1.7.36 as a dependency in this module, OR
  2. Upgrade to Logback 1.3.14 to match the parent POM's SLF4J 2.0.17 (but note this may conflict with Spring Boot 2.7.18's expectations)
Suggested change
</dependency>
</dependency>
<!-- Explicitly use SLF4J 1.7.x to match Logback 1.2.13 and avoid SLF4J 2.0.x from parent -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.36</version>
<scope>test</scope>
</dependency>

Copilot uses AI. Check for mistakes.
</dependencies>
</project>
9 changes: 5 additions & 4 deletions fesod-examples/fesod-sheet-examples/src/test/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@

-->
<configuration>
<include resource="org/springframework/boot/logging/logback/defaults.xml"/>

<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>${CONSOLE_LOG_PATTERN}</pattern>
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
<charset>utf8</charset>
</encoder>
</appender>

<root level="DEBUG">
<root level="INFO">
<appender-ref ref="CONSOLE"/>
</root>

<!-- Reduce noise from POI -->
<logger name="org.apache.poi" level="WARN"/>
</configuration>
9 changes: 5 additions & 4 deletions fesod-sheet/src/test/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@

-->
<configuration>
<include resource="org/springframework/boot/logging/logback/defaults.xml"/>

<appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
<encoder>
<pattern>${CONSOLE_LOG_PATTERN}</pattern>
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
<charset>utf8</charset>
</encoder>
</appender>

<root level="DEBUG">
<root level="INFO">
<appender-ref ref="CONSOLE"/>
</root>

<!-- Reduce noise from POI -->
<logger name="org.apache.poi" level="WARN"/>
</configuration>
38 changes: 8 additions & 30 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,13 @@
<poi.version>5.5.1</poi.version>
<ehcache.version>3.9.11</ehcache.version>
<commons-io.version>2.21.0</commons-io.version>
<slf4j-api.version>1.7.36</slf4j-api.version>
<slf4j-api.version>2.0.17</slf4j-api.version>
<lombok.version>1.18.42</lombok.version>
<spring-core.version>5.3.39</spring-core.version>
<fastjson2.version>2.0.60</fastjson2.version>
<spring-boot-starter-web.version>2.7.18</spring-boot-starter-web.version>
<slf4j-simple.version>1.7.36</slf4j-simple.version>
<jcl-over-slf4j.version>1.7.36</jcl-over-slf4j.version>
<log4j-over-slf4j.version>1.7.36</log4j-over-slf4j.version>
<logback-classic.version>1.5.24</logback-classic.version>
<log4j-to-slf4j.version>2.24.3</log4j-to-slf4j.version>
<logback-classic.version>1.3.14</logback-classic.version>
<mockserver.version>5.15.0</mockserver.version>
<jacoco.version>0.8.14</jacoco.version>
<junit.version>5.13.4</junit.version>
Expand Down Expand Up @@ -188,19 +186,9 @@
<version>${fastjson2.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<version>${slf4j-simple.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
<version>${jcl-over-slf4j.version}</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>log4j-over-slf4j</artifactId>
<version>${log4j-over-slf4j.version}</version>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-to-slf4j</artifactId>
<version>${log4j-to-slf4j.version}</version>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
Expand Down Expand Up @@ -299,18 +287,8 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>log4j-over-slf4j</artifactId>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-to-slf4j</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
Loading