[fix](search) fix MATCH_ALL_DOCS losing occur attribute in multi-field expansion#60873
Merged
airborne12 merged 1 commit intoapache:masterfrom Feb 27, 2026
Merged
[fix](search) fix MATCH_ALL_DOCS losing occur attribute in multi-field expansion#60873airborne12 merged 1 commit intoapache:masterfrom
airborne12 merged 1 commit intoapache:masterfrom
Conversation
…field expansion In lucene mode with multi-field queries like '"phrase" OR *', the standalone wildcard '*' is parsed as MATCH_ALL_DOCS with occur=SHOULD. However, during the cross-field expansion (expandNodeCrossFields, deepCopyWithField, setFieldOnLeaves), new MATCH_ALL_DOCS nodes were created without preserving the occur attribute. This caused the BE to default to MUST, changing the query semantics from "phrase OR match_all = all docs" to "phrase AND match_all = only phrase matches", producing results inconsistent with ES. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 28527 ms |
TPC-DS: Total hot run time: 183734 ms |
zclllyybb
approved these changes
Feb 27, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #DORIS-24561
Problem Summary:
In lucene mode with multi-field queries (e.g.,
best_fieldswithfields: ["title", "content"]), the query"Lauren Boebert" OR *returns results inconsistent with Elasticsearch.Root cause: During multi-field expansion (
expandNodeCrossFields,deepCopyWithField,setFieldOnLeaves),MATCH_ALL_DOCSnodes are recreated without preserving theoccurattribute (e.g.,SHOULD). The BE defaultsoccur=nulltoMUST, changing the query semantics:SHOULD(phrase) OR SHOULD(match_all)= all documentsSHOULD(phrase) AND MUST(match_all)= only phrase-matching documentsES explain for
"Lauren Boebert" OR *:Returns 1,000,000 docs (all). Doris was returning only phrase-matching docs.
Fix: Preserve the
occurattribute when creating newMATCH_ALL_DOCSnodes in all three multi-field expansion methods.Release note
Fix search() function returning incorrect results for lucene mode queries containing standalone wildcard
*with multi-field expansion (e.g.,"phrase" OR *withbest_fields).Check List (For Author)
Test
Behavior changed:
*(MATCH_ALL_DOCS) now correctly preserve theoccurattribute during cross-field expansion, matching ES behavior.Does this need documentation?
Check List (For Reviewer who merge this PR)