Add support for PostgreSQL's ORDER BY ... USING <operator> clause#2246
Open
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Open
Add support for PostgreSQL's ORDER BY ... USING <operator> clause#2246LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
LucaCappelletti94 wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parser and AST support for PostgreSQL
USINGoperators inORDER BYexpressions, including:ORDER BYORDER BY(e.g. insideaggfns(...)/string_agg(...)style clauses)Problem
sqlparser-rspreviously rejected valid PostgreSQL statements containing:ORDER BY <expr> USING <operator>with errors like:
Expected: ), found: usingThis blocked parsing of several PostgreSQL regression-style aggregate statements.
Root Cause
parse_order_by_expr_inneronly supported:ASC | DESCNULLS FIRST | NULLS LASTand had no branch to parse
USING <operator>.Dialect Scope Decision
ORDER BY ... USING <operator>is intentionally enabled for PostgreSQL only.Rationale:
ORDER BY expression [ USING operator ] ...inSELECT.ORDER BYwith expression +ASC|DESC(+ null ordering), but notUSING <operator>.References:
Complete Examples
PostgreSQL: accepted
PostgreSQL: rejected (invalid syntax)