CLVM enhancements and fixes by Pearl1594 · Pull Request #12617 · apache/cloudstack

Pearl1594 · 2026-02-09T19:47:40Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2026-02-09T20:01:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.68%. Comparing base (d3e1976) to head (df61d6f).
⚠️ Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d3e1976) and HEAD (df61d6f). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (d3e1976) HEAD (df61d6f)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #12617       +/-   ##
=============================================
- Coverage     17.90%    3.68%   -14.23%     
=============================================
  Files          5938      454     -5484     
  Lines        532864    38798   -494066     
  Branches      65192     7151    -58041     
=============================================
- Hits          95392     1428    -93964     
+ Misses       426793    37183   -389610     
+ Partials      10679      187    -10492

Flag	Coverage Δ
uitests	`3.67% <ø> (+<0.01%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…of running vm

Pearl1594 · 2026-02-11T19:43:29Z

@blueorangutan package

blueorangutan · 2026-02-11T19:44:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-11T20:28:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801

weizhouapache · 2026-02-17T15:02:13Z

...apshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java

        UserVmVO vm = userVmDao.findById(vmId);
        String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm);
+
+        if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) {


@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?

RAW @weizhouapache

codecov · 2026-02-17T15:24:41Z

Codecov Report

❌ Patch coverage is 13.63636% with 950 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.01%. Comparing base (d3e1976) to head (03a8860).
⚠️ Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java	0.00%	215 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	1.78%	165 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	15.88%	88 Missing and 2 partials ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	76 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	21.73%	70 Missing and 2 partials ⚠️
...tack/storage/endpoint/DefaultEndPointSelector.java	0.00%	65 Missing ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java	16.36%	45 Missing and 1 partial ⚠️
...wrapper/LibvirtClvmLockTransferCommandWrapper.java	4.76%	40 Missing ⚠️
...rce/wrapper/LibvirtPreMigrationCommandWrapper.java	7.40%	25 Missing ⚠️
...stack/storage/command/ClvmLockTransferCommand.java	40.00%	21 Missing ⚠️
... and 16 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12617      +/-   ##
============================================
+ Coverage     17.90%   18.01%   +0.11%     
- Complexity    16094    16434     +340     
============================================
  Files          5938     5947       +9     
  Lines        532864   540433    +7569     
  Branches      65192    67848    +2656     
============================================
+ Hits          95392    97368    +1976     
- Misses       426793   432243    +5450     
- Partials      10679    10822     +143

Flag	Coverage Δ
uitests	`3.69% <ø> (+0.02%)`	⬆️
unittests	`19.12% <13.63%> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594 · 2026-02-18T16:33:12Z

@blueorangutan package

blueorangutan · 2026-02-18T16:40:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T17:32:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875

Pearl1594 · 2026-02-18T20:23:11Z

@blueorangutan package

blueorangutan · 2026-02-18T20:24:04Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-18T21:16:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877

…ached volumes

Pearl1594 · 2026-02-20T04:24:55Z

@blueorangutan package

blueorangutan · 2026-02-20T04:26:05Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-20T05:18:46Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16890

…ity for clvm

Pearl1594 · 2026-02-25T01:29:07Z

@blueorangutan package

blueorangutan · 2026-02-25T01:30:03Z

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-25T02:33:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16932

Pearl1594 · 2026-02-25T15:22:41Z

@blueorangutan test

blueorangutan · 2026-02-25T15:24:03Z

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-02-26T06:46:10Z

[SF] Trillian test result (tid-15528)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52330 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12617-t15528-kvm-ol8.zip
Smoke tests completed. 149 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_LoginApiDomain	`Error`	6.92	test_accounts.py

2. handle attaching volumes to stopped VMs \n 3. Handle lock transfer when VM is started on another host

sonarqubecloud · 2026-02-26T22:50:14Z

Quality Gate failed

Failed conditions
1 Security Hotspot
10.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

boring-cyborg bot added component:kvm component:storage labels Feb 9, 2026

CLVM enhancements and fixes

9e03f4b

Pearl1594 force-pushed the clvm-enhancements branch from 5fc1f12 to 9e03f4b Compare February 9, 2026 21:39

Pearl1594 added 2 commits February 10, 2026 19:48

add support for proper cleanup of snapshots and prevent vol snapshot …

96edadc

…of running vm

remove snap vol restriction for sunning vms

f9d8062

harikrishna-patnala added this to the 4.23.0 milestone Feb 17, 2026

weizhouapache reviewed Feb 17, 2026

View reviewed changes

Pearl1594 force-pushed the clvm-enhancements branch from a08e7a5 to df61d6f Compare February 17, 2026 15:04

refactor clvm code

43e9384

Pearl1594 force-pushed the clvm-enhancements branch from df61d6f to 43e9384 Compare February 17, 2026 15:16

boring-cyborg bot added component:api component:compute component:orchestration labels Feb 17, 2026

add support for live migration

c9dd7ed

Pearl1594 force-pushed the clvm-enhancements branch from 3f900e8 to c9dd7ed Compare February 17, 2026 22:54

add support for migrating lvm lock

4984ee5

Pearl1594 added 2 commits February 19, 2026 15:42

clvm deletion called explicitly

190b201

made necessary changes to allow migration of lock and deletion of det…

8a7e48a

…ached volumes

Pearl1594 force-pushed the clvm-enhancements branch from 8fb082c to 8a7e48a Compare February 20, 2026 01:25

fix create vol from snap and attach

ab98daa

Pearl1594 added 6 commits February 20, 2026 07:50

add support to revert snapshot for clvm

6f20113

add support to revert snapshot for clvm

21242ac

make zero fill configurable

7a11626

make setting non-dynamic & fix test

82d6edd

fix locking at vol/vm creation

7b5af5e

fix revert snapshot format type and handle revert snapshot functional…

d8890ec

…ity for clvm

boring-cyborg bot added the component:primary-storage label Feb 25, 2026

Pearl1594 added 4 commits February 26, 2026 15:46

1. Create clvmlockmanager and move common code \n

d93e044

2. handle attaching volumes to stopped VMs \n 3. Handle lock transfer when VM is started on another host

add license

16f319d

add unit tests

b3e0bb5

remove command/answer classes from sonar coverage check

c83affd

boring-cyborg bot added the component:build label Feb 26, 2026

Pearl1594 added 2 commits February 26, 2026 16:44

fix failing test and add test

ed7cf12

add unit test for helper class

03a8860

Pearl1594 force-pushed the clvm-enhancements branch from 6814a77 to 03a8860 Compare February 26, 2026 21:50

Conversation

Pearl1594 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

blueorangutan commented Feb 11, 2026

Uh oh!

weizhouapache Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Pearl1594 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

blueorangutan commented Feb 18, 2026

Uh oh!

Pearl1594 commented Feb 20, 2026

Uh oh!

blueorangutan commented Feb 20, 2026

Uh oh!

blueorangutan commented Feb 20, 2026

Uh oh!

Pearl1594 commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 25, 2026

Uh oh!

Pearl1594 commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 26, 2026

Uh oh!

sonarqubecloud bot commented Feb 26, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pearl1594 commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

codecov bot commented Feb 17, 2026 •

edited

Loading