CASSANDRA-21196: Include tools in applyCompatibilityMode check#4663
Open
thisteensy wants to merge 1 commit intoapache:cassandra-5.0from
Open
CASSANDRA-21196: Include tools in applyCompatibilityMode check#4663thisteensy wants to merge 1 commit intoapache:cassandra-5.0from
thisteensy wants to merge 1 commit intoapache:cassandra-5.0from
Conversation
uses correct compound method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASSANDRA-21196: Include tools in applyCompatibilityMode check
Problem
The
applyCompatibilityMode()method only checkedisClientInitialized()when setting
StorageCompatibilityMode.NONE, despite the comment stating"tools or clients should not limit the sstable formats they support."
Tools were inadvertently falling through to the
else ifbranch andpotentially having their sstable format support restricted.
Solution
Added
isClientOrToolInitialized()to the condition so tools correctly receiveStorageCompatibilityMode.NONE, consistent with the existing behaviorfor clients.
patch by Tina Haiser; reviewed by @driftx for CASSANDRA-21196