ARTEMIS-5925 Support Star Mirror Configuration on Lock Coordinator#6268
Merged
clebertsuconic merged 1 commit intoapache:mainfrom Mar 3, 2026
Merged
ARTEMIS-5925 Support Star Mirror Configuration on Lock Coordinator#6268clebertsuconic merged 1 commit intoapache:mainfrom
clebertsuconic merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@tabish121 I need your help defining what pause / resume would means on Bridge / Federations. In Mirror should mean everything is connected but we are not capturing events.. To allow previous events to flow even if the mirror is paused (say right after a failure). |
tabish121
reviewed
Mar 2, 2026
...c/main/java/org/apache/activemq/artemis/protocol/amqp/connect/bridge/AMQPBridgeManagers.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederationSource.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java
Outdated
Show resolved
Hide resolved
dcb47c6 to
1c9f770
Compare
Contributor
Author
|
all I need to do before setting ready to review is to add tests to parse the XML... and change documentation.. I will finish it shortly. I know there's some checkstyle issues, which I will also fix. |
4993631 to
3fd9e18
Compare
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Mar 2, 2026
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java
Outdated
Show resolved
Hide resolved
3fd9e18 to
8517f19
Compare
tabish121
reviewed
Mar 2, 2026
artemis-server/src/main/resources/schema/artemis-configuration.xsd
Outdated
Show resolved
Hide resolved
tabish121
previously requested changes
Mar 2, 2026
tabish121
reviewed
Mar 2, 2026
...ol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java
Outdated
Show resolved
Hide resolved
5ad7341 to
59412ae
Compare
59412ae to
4d1509a
Compare
tabish121
previously requested changes
Mar 3, 2026
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java
Outdated
Show resolved
Hide resolved
4d1509a to
3d36377
Compare
59c82aa to
e97fcfe
Compare
Disclaimer: The test StarMirrorSingleAcceptorRunningTest was written with the help from Claude agent. I basically asked Claude to copy it from DualMirrorSingleAcceptorRunning with the additional configuration options.
e97fcfe to
bd376a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: The test StarMirrorSingleAcceptorRunningTest was written with the help from Claude agent. I basically asked Claude to copy it from DualMirrorSingleAcceptorRunning with the additional configuration options.