Skip to content

ARTEMIS-5925 Support Star Mirror Configuration on Lock Coordinator#6268

Merged
clebertsuconic merged 1 commit intoapache:mainfrom
clebertsuconic:ARTEMIS-5925
Mar 3, 2026
Merged

ARTEMIS-5925 Support Star Mirror Configuration on Lock Coordinator#6268
clebertsuconic merged 1 commit intoapache:mainfrom
clebertsuconic:ARTEMIS-5925

Conversation

@clebertsuconic
Copy link
Contributor

Disclaimer: The test StarMirrorSingleAcceptorRunningTest was written with the help from Claude agent. I basically asked Claude to copy it from DualMirrorSingleAcceptorRunning with the additional configuration options.

@clebertsuconic clebertsuconic marked this pull request as draft March 2, 2026 15:04
@clebertsuconic clebertsuconic requested a review from tabish121 March 2, 2026 15:04
@clebertsuconic
Copy link
Contributor Author

clebertsuconic commented Mar 2, 2026

@tabish121 I need your help defining what pause / resume would means on Bridge / Federations.

In Mirror should mean everything is connected but we are not capturing events.. To allow previous events to flow even if the mirror is paused (say right after a failure).

@clebertsuconic
Copy link
Contributor Author

all I need to do before setting ready to review is to add tests to parse the XML... and change documentation.. I will finish it shortly.

I know there's some checkstyle issues, which I will also fix.

@clebertsuconic clebertsuconic force-pushed the ARTEMIS-5925 branch 3 times, most recently from 4993631 to 3fd9e18 Compare March 2, 2026 23:14
@clebertsuconic clebertsuconic marked this pull request as ready for review March 2, 2026 23:15
@clebertsuconic clebertsuconic force-pushed the ARTEMIS-5925 branch 6 times, most recently from 5ad7341 to 59412ae Compare March 3, 2026 03:12
@clebertsuconic clebertsuconic dismissed tabish121’s stale review March 3, 2026 14:11

I applied it manually

@clebertsuconic clebertsuconic dismissed tabish121’s stale review March 3, 2026 18:07

I have made the changes.

@clebertsuconic clebertsuconic force-pushed the ARTEMIS-5925 branch 2 times, most recently from 59c82aa to e97fcfe Compare March 3, 2026 18:15
Disclaimer: The test StarMirrorSingleAcceptorRunningTest was written with the help
from Claude agent. I basically asked Claude to copy it from
DualMirrorSingleAcceptorRunning with the additional configuration
options.
@clebertsuconic clebertsuconic merged commit 0074895 into apache:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants