Skip to content

Avoid Divide by 0 in compute Deviation Ratio #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandoniles wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid Divide by 0 in compute Deviation Ratio #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spot-contracts/contracts/FeePolicy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ contract FeePolicy is IFeePolicy, OwnableUpgradeable {
/// @inheritdoc IFeePolicy
function computeDeviationRatio(SystemTVL memory s) public view override returns (uint256) {
// NOTE: We assume that perp's TVL and vault's TVL values have the same base denomination.
return s.vaultTVL.mulDiv(ONE, s.perpTVL).mulDiv(ONE, targetSystemRatio);
uint256 perpTVL = (s.perpTVL > 0) ? s.perpTVL : 0x1;
return s.vaultTVL.mulDiv(ONE, perpTVL).mulDiv(ONE, targetSystemRatio);
}
}