Conversation
Contributor
|
The WebVTT is being embedded into the MP4, but it's getting cutoff around the 43 minute mark. I've attached the original WebVTT and an SRT that I extracted from the MP4. You'll see that the SRT cuts off around 43 minutes, whereas the WebVTT continues to the full hour. |
Member
Author
|
@iamdamosuzuki can you share the scc? |
Contributor
This prevents immediate blank lines after the vtt timestamp and swaps \h for spaces
Member
Author
|
Hi @iamdamosuzuki, it should work on that source after the most recent patch here. |
iamdamosuzuki
approved these changes
Mar 2, 2026
Contributor
iamdamosuzuki
left a comment
iamdamosuzuki
left a comment
There was a problem hiding this comment.
This is working now. Did a 60 min capture with the same source as before and the embedded captions worked in the MP4 throughout the entire file. thank you!
Merged
privatezero
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.