fix: improve link checker workflow reliability and comment display#1104
Merged
dslovinsky merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: improve link checker workflow reliability and comment display#1104dslovinsky merged 2 commits intomainfrom
dslovinsky merged 2 commits intomainfrom
Conversation
The bootstrap step only primes lychee's cookie jar for draft-mode auth. Link validation happens in the subsequent Link Checker step, so errors here should not block the workflow. Co-Authored-By: Claude <noreply@anthropic.com>
Hide the Summary section and result message when the link checker is in progress, skipped, or cancelled. Only display them for terminal states (success/failure) where the report data is meaningful. Co-Authored-By: Claude <noreply@anthropic.com>
🔗 Preview Mode
|
🔍 Link CheckStatus: ⏭️ Skipped (no content changes) |
SahilAujla
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail: true→fail: falseon the cookie priming step so transient errors (e.g., stale redirects on preview site) don't block the real link checkerExamples:
Fixes the false failure in run #22730587369.
Fixes these awkward states in which summaries aren't necessary or are actively misleading.
Test plan