Add V2 Importer for Tuxcare advisories#2104
Add V2 Importer for Tuxcare advisories#2104Samk1710 wants to merge 10 commits intoaboutcode-org:mainfrom
Conversation
vulnerabilities/tests/pipelines/v2_importers/test_tuxcare_importer_v2.py
Outdated
Show resolved
Hide resolved
|
@ziadhany Thanks for your review. |
|
@Samk1710, could you please also fix the CI ? |
|
Hey @ziadhany |
|
Hey @ziadhany |
|
Hey @ziadhany I have rectified the PURL. Also added more data to test each OS type with their respective PURLs. Kindly review the changes when you have time. Thanks. |
|
Hey @ziadhany |
0f27746 to
7d47d46
Compare
ziadhany
left a comment
There was a problem hiding this comment.
The code looks good, just a few nits.
e4e1684 to
66be491
Compare
Thanks @ziadhany |
66be491 to
9597abf
Compare
|
Hey @ziadhany. Could you kindly have a look at the changes when time. Thanks. |
| VERSION_RANGE_BY_PURL_TYPE = { | ||
| "rpm": RANGE_CLASS_BY_SCHEMES["rpm"], | ||
| "deb": RANGE_CLASS_BY_SCHEMES["deb"], | ||
| "apk": AlpineLinuxVersionRange, | ||
| "generic": RANGE_CLASS_BY_SCHEMES["generic"], | ||
| } |
There was a problem hiding this comment.
why this ?
| VERSION_RANGE_BY_PURL_TYPE = { | |
| "rpm": RANGE_CLASS_BY_SCHEMES["rpm"], | |
| "deb": RANGE_CLASS_BY_SCHEMES["deb"], | |
| "apk": AlpineLinuxVersionRange, | |
| "generic": RANGE_CLASS_BY_SCHEMES["generic"], | |
| } | |
| from univers.version_range import RANGE_CLASS_BY_SCHEMES |
There was a problem hiding this comment.
@ziadhany
alpine does not exist in RANGE_CLASS_BY_SCHEME. An existing issue is also open
See : aboutcode-org/univers#112
We need to add this to proceed.
There was a problem hiding this comment.
|
|
||
| return PackageURL( | ||
| type=pkg_type, namespace=namespace, name=project_name, qualifiers=qualifiers | ||
| ) |
There was a problem hiding this comment.
Please add a unit test to cover this function.
e8d2186 to
d7ed5f2
Compare
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
d7ed5f2 to
07a5af2
Compare
Signed-off-by: Sampurna Pyne <sampurnapyne1710@gmail.com>
07a5af2 to
37938ee
Compare
|
@ziadhany Done with the changes. Please have a look when time |
Addresses Issue:
Data Source: https://cve.tuxcare.com/els/download-json?orderBy=updated-desc
Importer Log Excerpt: