Skip to content

refactor: use TransportProtocol enum in examples AgentCardProducer#696

Open
CokeLee777 wants to merge 1 commit intoa2aproject:mainfrom
CokeLee777:refactor/use-transport-protocol-enum-in-examples
Open

refactor: use TransportProtocol enum in examples AgentCardProducer#696
CokeLee777 wants to merge 1 commit intoa2aproject:mainfrom
CokeLee777:refactor/use-transport-protocol-enum-in-examples

Conversation

@CokeLee777
Copy link
Contributor

@CokeLee777 CokeLee777 commented Mar 3, 2026

Description

Replace the raw string switch statement with an exhaustive switch expression based on the TransportProtocol enum.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and maintainability of protocol configuration within the AgentCardProducer example. By transitioning from raw string comparisons to an enum-driven switch expression, the code now benefits from compile-time safety for protocol handling and immediate validation of configuration inputs, making it more resilient to future changes and misconfigurations.

Highlights

  • Refactored Protocol Handling: Replaced a string-based switch statement with an exhaustive switch expression utilizing the TransportProtocol enum for handling different communication protocols.
  • Improved Validation: Introduced TransportProtocol.fromString() to parse the protocol string, providing fail-fast validation for invalid configuration values.
  • Enhanced Maintainability: Removed the default clause from the switch expression, ensuring compile-time updates are enforced if new protocols are added to the TransportProtocol enum.
Changelog
  • examples/helloworld/server/src/main/java/io/a2a/examples/helloworld/AgentCardProducer.java
    • Reordered and consolidated import statements for io.a2a.spec classes.
    • Updated the getAgentInterface method to use TransportProtocol.fromString() and a switch expression for protocol handling.
    • Removed the default case from the protocol switch logic to ensure exhaustive handling of TransportProtocol enum values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the AgentCardProducer to use the TransportProtocol enum instead of raw strings for handling different protocols. This is a good improvement that increases type safety and makes the code more robust against future changes to the enum. The suggestion to further simplify the implementation by leveraging Quarkus's type conversion capabilities to inject the enum directly remains valid and would make the code even cleaner.

@CokeLee777 CokeLee777 closed this Mar 3, 2026
@CokeLee777 CokeLee777 reopened this Mar 4, 2026
Replace the raw string switch statement with an exhaustive switch expression based on the TransportProtocol enum. Using fromString() provides fail-fast validation on invalid config values, and removing the default clause enforces compile-time updates when new protocols are added to the enum.
@CokeLee777 CokeLee777 force-pushed the refactor/use-transport-protocol-enum-in-examples branch from 4757bc4 to 5a44143 Compare March 4, 2026 04:02
@CokeLee777
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the AgentCardProducer to use the TransportProtocol enum instead of raw strings for protocol handling, which is a solid improvement. My review includes suggestions to further improve code quality by avoiding wildcard imports and magic strings, as these practices are not relaxed for production code.

@CokeLee777 CokeLee777 closed this Mar 4, 2026
@CokeLee777 CokeLee777 reopened this Mar 4, 2026
@CokeLee777
Copy link
Contributor Author

TCK CI failed because of #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant