Add wp prefix to enable_real_time_collaboration option.#11001
Add wp prefix to enable_real_time_collaboration option.#11001peterwilsoncc wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
The changes make sense to me. Minor comment.
chriszarate
left a comment
There was a problem hiding this comment.
Noting only that changing the option name will turn off real-time collaboration for anyone who has turned it on previously using the beta 1 release. (I think this is fine.)
4bba68b to
34fb4ee
Compare
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
34fb4ee to
4c02ea2
Compare
Yeah, I'm fine with that too as it hasn't been in a production version. For the associated Gutenberg PR, I've included a migration because the feature has been active in the plugin for a little longer. WordPress/gutenberg#75837 |
Renames the option
enable_real_time_collaborationtowp_enable_real_time_collaborationto follow convention since WordPress 5.8 to prefix new core options withwp.Trac ticket: https://core.trac.wordpress.org/ticket/64622#comment:34
Use of AI Tools
Nil.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.