Loosen kebab-case rules to allow non-first fragments to start with numbers#592
Merged
lukewagner merged 2 commits intomainfrom Jan 8, 2026
Merged
Loosen kebab-case rules to allow non-first fragments to start with numbers#592lukewagner merged 2 commits intomainfrom
lukewagner merged 2 commits intomainfrom
Conversation
lukewagner
force-pushed
the
loosen-kebab
branch
from
c3263b3 to
e3b393f
Compare
esoterra
approved these changes
Jan 6, 2026
alexcrichton
approved these changes
Jan 6, 2026
dicej
approved these changes
Jan 6, 2026
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Thanks!
Would you mind updating https://github.com/WebAssembly/component-model/blob/b7fc86e31d71796f107aef276f0944ec6df70dba/test/wasm-tools/naming.wast#L25C1-L30C2 as well?
Member
Author
lukewagner
force-pushed
the
loosen-kebab
branch
from
5777957 to
e38aa2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (belated) PR makes the changes discussed in #345, bringing the spec in line with the current wasm-tools implementation.