Reran CFReT dataset with Buscar update#75
Open
axiomcura wants to merge 26 commits intoWayScience:mainfrom
Open
Reran CFReT dataset with Buscar update#75axiomcura wants to merge 26 commits intoWayScience:mainfrom
axiomcura wants to merge 26 commits intoWayScience:mainfrom
Conversation
…alysis.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…alysis.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…_base_on_moa.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…alysis.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…otypic-activity.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ores.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CFReT analysis notebooks/outputs to align with the redesigned Buscar workflow in #74 (notably removing the clustering/centroid portions), and reruns downstream plotting/analysis artifacts accordingly.
Changes:
- Switch notebook preprocessing to use
buscar.preprocessand update the CFReT pilot analysis to use the updated Buscar metrics/signatures workflow (no clustering). - Add a KS-test + FDR-based “signature importance” analysis and new plotting scripts (PCA comparisons, volcano-style significance plots).
- Update generated notebook artifacts/figures and bump the Ruff pre-commit hook revision.
Reviewed changes
Copilot reviewed 14 out of 33 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| notebooks/2.cfret-analysis/plots/nbconverted/3.cfret-signature-volcano-plot.r | New significance scatter plots (by channel and by on/off signature). |
| notebooks/2.cfret-analysis/plots/nbconverted/2.sc-agg-consensus-pca-plot.r | New PCA plot comparing single-cell vs aggregate profiles. |
| notebooks/2.cfret-analysis/plots/nbconverted/1.on-and-off-pca-and-umap-plots.r | Adds clarifying header comments and small formatting/comment tweaks. |
| notebooks/2.cfret-analysis/plots/figures/well_cluster_heatmap.png | Updated/generated figure artifact. |
| notebooks/2.cfret-analysis/plots/figures/data_rep_heatmap.png | Updated/generated figure artifact. |
| notebooks/2.cfret-analysis/plots/figures/data_rep_heatmap.pdf | Updated/generated figure artifact (PDF). |
| notebooks/2.cfret-analysis/nbconverted/4.generate-pca-umap-components.py | Switch imports to buscar.preprocess for PCA/UMAP. |
| notebooks/2.cfret-analysis/nbconverted/4.assess-signature-significance.py | New script to compute KS-test + FDR “signature importance” table. |
| notebooks/2.cfret-analysis/nbconverted/3.generate-pca-umap-components.py | New script to generate PCA/UMAP embeddings for on/off/all feature sets. |
| notebooks/2.cfret-analysis/nbconverted/3.generate-centroid.py | Removed centroid-generation (clustering workflow no longer used). |
| notebooks/2.cfret-analysis/nbconverted/1.cfret-pilot-buscar-analysis.py | Update pilot analysis to new Buscar workflow (signatures + phenotypic activity; no clustering). |
| notebooks/2.cfret-analysis/4.assess-signature-significance.ipynb | New notebook version of the signature significance analysis. |
| notebooks/2.cfret-analysis/3.generate-pca-umap-components.ipynb | Updated notebook to use buscar.preprocess and refreshed outputs/metadata. |
| notebooks/2.cfret-analysis/3.generate-centroid.ipynb | Removed centroid notebook (clustering workflow removed). |
| notebooks/2.cfret-analysis/2.generate-aggregate-profiles.ipynb | Notebook metadata update (Python version change). |
| notebooks/2.cfret-analysis/1.cfret-pilot-buscar-analysis.ipynb | Updated notebook to use Buscar modules directly; removes clustering steps. |
| .pre-commit-config.yaml | Bumps Ruff hook revision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
notebooks/2.cfret-analysis/nbconverted/4.assess-signature-significance.py
Show resolved
Hide resolved
notebooks/2.cfret-analysis/nbconverted/4.assess-signature-significance.py
Show resolved
Hide resolved
notebooks/2.cfret-analysis/plots/nbconverted/3.cfret-signature-volcano-plot.r
Show resolved
Hide resolved
notebooks/2.cfret-analysis/plots/nbconverted/3.cfret-signature-volcano-plot.r
Show resolved
Hide resolved
notebooks/2.cfret-analysis/plots/nbconverted/2.sc-agg-consensus-pca-plot.r
Show resolved
Hide resolved
notebooks/2.cfret-analysis/plots/nbconverted/1.on-and-off-pca-and-umap-plots.r
Outdated
Show resolved
Hide resolved
notebooks/2.cfret-analysis/nbconverted/3.generate-pca-umap-components.py
Show resolved
Hide resolved
…ificance.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…alysis.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ificance.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reruns the CFReT dataset with the updated Buscar implementation in #74
Note: Once #74 is merged, I will update this branch