Added Swift Package Manager Support#2134
Open
xquezme wants to merge 1 commit intoTextureGroup:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift Package Manager Support
Adds first-class SPM support, including source reorganization, a module map, opt-in traits for optional integrations, smoke tests, and CI coverage.
Package manifest (
Package.swift)AsyncDisplayKitas a static library productTraits
Traits are disabled by default. Only the dependencies you explicitly enable are resolved.
IGListKitAS_IG_LIST_KIT,AS_IG_LIST_DIFF_KITYogaYOGASource reorganization
All sources moved from
Source/→Source/Texture/, with public headers consolidated underSource/Texture/include/to satisfy SPM'spublicHeadersPathrequirement. Amodule.modulemapwas added to correctly expose theAsyncDisplayKitumbrella module with explicit submodules forASControlNode+SubclassesandASDisplayNode+Subclasses.Smoke tests (
smoke-tests/)Three minimal test targets that validate SPM resolution and compilation end-to-end:
SwiftPackageManagerIntegration— baseline check: importsAsyncDisplayKit, creates anASDKViewController<ASTextNode>IGListKitIntegration— validates theIGListKittrait: implements aListSectionControllerusingASSectionControllerandASIGListSectionControllerMethodsYogaIntegration— validates theYogatrait: exercises Yoga-specific layout API (flexGrow,flexShrink,alignSelf) that is only available whenYOGA=1CI
Added a
spm-smoke-testsmatrix job to.github/workflows/ci.ymlthat builds all three smoke test targets on every PR.Other
Texture.podspec— updated source file globs and header paths to match the newSource/Texture/layoutREADME.md— added SPM installation section and badgebuild.sh— updated to support the newspm-smoke-testsbuild mode