Skip to content

Comments

SC-41129 Refactor customForConfiguration from Java expression to JS function#6437

Open
vdiez wants to merge 1 commit intomasterfrom
SC-41129
Open

SC-41129 Refactor customForConfiguration from Java expression to JS function#6437
vdiez wants to merge 1 commit intomasterfrom
SC-41129

Conversation

@vdiez
Copy link
Contributor

@vdiez vdiez commented Feb 23, 2026

Summary

  • Moved customForConfiguration from a Java expression string to a JS function, so parameter transformations apply in both HTTP bridge and gRPC paths
  • S1441 (quotes) now correctly transforms boolean true/false to "single"/"double" in gRPC path
  • S6418 (hard-coded secrets) randomnessSensibility string-to-number conversion now handled in JS
  • Removed Java expression inlining from generate-java-rule-classes.ts; generated Java classes now send raw field values

Test plan

  • S1441 gRPC test now passes (was previously failing)
  • S6418 and S7718 gRPC tests still pass
  • Full gRPC server test suite passes (31/31)
  • Type-check passes (npx tsc -b packages)
  • Verify Java integration tests pass in CI

🤖 Generated with Claude Code

…unction

Move parameter transformations from Java to Node.js so they apply in both
HTTP bridge and gRPC paths. customForConfiguration is now a JS function
applied in the linter instead of a Java expression string inlined in
generated check classes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdiez vdiez requested a review from a team February 23, 2026 15:57
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Feb 23, 2026

SC-41129

@vdiez vdiez requested a review from zglicz February 23, 2026 15:59
@github-actions
Copy link
Contributor

Ruling Report

No changes to ruling expected issues in this PR

@sonarqube-next
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
2 New issues

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant