chore: switch package managers to pnpm by fredericoo · Pull Request #3475 · Shopify/hydrogen

fredericoo · 2026-02-18T12:24:06Z

Closes https://github.com/Shopify/developer-tools-team/issues/1061

How to test

Install pnpm if you haven’t (npm i -g pnpm@10.16.1)
After checking out to the repo, remove all local files:

pnpm nuke

install packages pnpm i
build pnpm run build
typecheck pnpm run typecheck
tests pnpm run test (might need to disable lockdown on your laptop. if you get EPIPE that’s because of that, this is nothing new to this branch)
e2e pnpm run e2e

Compiling template for dist (used in release.yml)

node scripts/compile-template-for-dist.mjs skeleton --keep

Verify no protocols remain:

rg "workspace:|catalog:" templates/skeleton-ts/package.json templates/skeleton-js/package.json (expect no matches)

fredericoo · 2026-02-19T14:50:39Z

packages/cli/src/commands/hydrogen/upgrade.test.ts

  });

  describe('displayDevUpgradeNotice', () => {
+    it('shows a monorepo notice when Hydrogen uses workspace protocol', async () => {


this is a "feature"

we were getting a warning when running the skeleton app because workspace:* is not a valid version of hydrogen as per our CLI

so now we just get an info letting us know that we are running the monorepo’d version of it

this will only take effect after @andguy95 ’s fixes to locally overriding cli-hydrogen when using the shopify cli

for now we will get Invalid comparator: workspace: when starting skeleton

fredericoo · 2026-02-19T14:52:16Z

packages/cli/src/lib/onboarding/local.ts

      recursive: true,
      filter: (filepath: string) =>
-        !/^(app\/|dist\/|node_modules\/|server\.ts|\.shopify\/)/i.test(
+        !/^(app(\/|$)|dist(\/|$)|node_modules(\/|$)|server\.ts$|\.shopify(\/|$))/i.test(


this regex used to only catch files within those folders (ending with forward slash)

because pnpm has a folder with symlinks, it was breaking

simple change now makes the files match either a forward slash or the end of the string (\/|$)

fredericoo · 2026-02-19T14:55:41Z

packages/cli/src/lib/template-pack.ts

this is a caveat of using workspace:* versions

Before

npm used to just detect "oh there is a package with the name "@shopify/hydrogen" in this repo, i should treat all imports to that as the imports from the monorepo then"

After

pnpm does not do that automatically. You have to say you want to use the workspace version by setting it as workspace:*

Because of that, skeleton has some packages with workspace or catalog versions, which we need to pack into the real versions

pnpm has a pack script to do that, but we need to also do this in runtime code sometimes

fredericoo · 2026-02-19T14:56:33Z

packages/create-hydrogen/package.json

    "@ast-grep/napi": "0.34.1"
  },
  "devDependencies": {
+    "@types/node": "catalog:",


whenever you see this it’s because it was being automatically hoisted by npm (installed somewhere else entirely, but picked up by npm) and now we have to be explicit

fredericoo · 2026-02-19T14:58:11Z

packages/hydrogen-react/tsconfig.json

    "declaration": true,
    "declarationDir": "./dist/types",
    "jsx": "react-jsx",
-    "types": ["vitest/globals", "jest", "@testing-library/jest-dom"]


jest!!! we seem to have migrated to vitest a while ago

fredericoo · 2026-02-19T14:58:53Z

packages/hydrogen-react/vitest.setup.ts

-import {expect} from 'vitest';
-
-expect.extend(matchers);
+import '@testing-library/jest-dom/vitest';


as per https://testing-library.com/docs/svelte-testing-library/setup/#vitest

fredericoo · 2026-02-19T14:59:23Z

packages/hydrogen/package.json

-    "@shopify/hydrogen-codegen": "*",
-    "@testing-library/jest-dom": "^5.17.0",
+    "@shopify/hydrogen-codegen": "workspace:*",
+    "@testing-library/jest-dom": "^6.6.3",


bumped so we could use the vitest intended way: https://testing-library.com/docs/svelte-testing-library/setup/#vitest

fredericoo · 2026-02-19T15:07:02Z

turbo.json

@@ -1,14 +1,15 @@
 {
-  "$schema": "https://turborepo.org/schema.json",
+  "$schema": "./node_modules/turbo/schema.json",


read schema from the actual installed turborepo version

turbo.json

fredericoo · 2026-02-19T15:18:40Z

pnpm-workspace.yaml

+catalog:
+  '@types/node': '^22'
+  '@types/react': '^18.3.28'
+  '@types/react-dom': '^18.3.7'
+  react: '^18.3.1'
+  react-dom: '^18.3.1'


this is AWESOME

here we can keep the version for packages we want, and they will be used where you define catalog: as a version

https://pnpm.io/catalogs

thank god!! I ran into package/-lock.json merge conflicts 3 times when trying to do the 2025-10 recipe migration and every time merging into main, it caused so many tests and shit to fail >:(

.github/workflows/snapit.yml

package.json

kdaviduik

some comments (mainly just notes/follow ups) but overall LGTM! nice work, now we're on the green path and won't need to worry about people making issues in the Hydrogen repo because our stuff breaks with pnpm install :D

kdaviduik · 2026-02-23T04:47:38Z

packages/cli/src/lib/template-pack.test.ts

+import {getSkeletonSourceDir} from './build.js';
+import {replaceWorkspaceProtocolVersions} from './template-pack.js';
+
+const DEPENDENCY_SECTIONS = [


(threading)

This module sits in the critical path of every production release (called by compile-template-for-dist.mjs to resolve workspace: and catalog: protocols). Right now there's one happy-path integration test which is a good start, but I think we should add a few more cases — this is the kind of module where a failure at release time blocks publishing and is painful to debug in CI.

Some things I'd want to see covered (could be a follow-up):

What happens when a dep has workspace: protocol but isn't in the packed manifest? (currently throws, but is the error message clear enough?)

Does the catalog: path specifically resolve to the correct version? (the test sets it up on line 30 but only asserts the prefix is gone, not that the resolved value is right)

I'm fine with this being done a follow-up issue though

kdaviduik · 2026-02-23T04:48:20Z

.github/workflows/test-calver.yml

      - name: Checkout
        uses: actions/checkout@v4

+      - name: Setup pnpm


(threading)

nit: test-calver.yml (line 60) and test-upgrade-flow.yml (line 56) specify cache: 'pnpm' but omit cache-dependency-path: 'pnpm-lock.yaml'. Every other workflow includes it. Without it, setup-node searches for the lockfile automatically which usually works but can behave unexpectedly in monorepos. Would be nice to add for consistency.

kdaviduik · 2026-02-23T04:49:32Z

.github/workflows/test-calver.yml

        with:
          node-version: 18
-          cache: 'npm'
+          cache: 'pnpm'


Hmmm test-calver.yml uses node-version: 18 while all other workflows use Node 22 or 24, and the root package.json engines field specifies "node": "^22 || ^24". I think we should bump this to use the same node version as the rest of the CI workflows.

out of scope for this PR but we should do it as a follow-up

yeah it was 18 before, so i chose not to touch it when bumping to 22+

will do this as a followup PR

andguy95

Looks good to me!

fredericoo added 12 commits February 17, 2026 12:11

fix: npm audit vulnerabilities

3a09c1a

chore: move overrides to root

23d3617

chore: migrate package to rr7

072c501

chore: migrate package to rr7

64bb0bc

type: excessive casting from llm

5137212

Merge remote-tracking branch 'origin/main' into fb-audit-2

6e6e235

chore(deps): remove transitive dep

7a73438

chore: migrate to pnpm

a31a151

chore(deps): upgrade turbo

06be277

fix: dev:app command

2547bc5

chore: workspace deps

47fc94a

fix: workspace package version replacing

36cea4c

github-actions bot added the cla-needed label Feb 18, 2026

Merge remote-tracking branch 'origin/main' into fb-npm2pnpm

19ed652

fredericoo changed the title ~~fb npm2pnpm~~ chore: migrate to pnpm Feb 18, 2026

fredericoo added 5 commits February 18, 2026 12:31

ci: setup pnpm

dcf7ebf

fix: setup pnpm before node

1e2afa0

chore(deps): stable node types version

c51ffe8

refactor: reuse packing logic

f322e41

fix: cli hoisting node deps now broken

520d27b

fredericoo removed the cla-needed label Feb 19, 2026

ci: remove rebuild, remove types from typeoutput

348c000

github-actions bot added the cla-needed label Feb 19, 2026

fredericoo removed the cla-needed label Feb 19, 2026

fix: missing react types declaration

1e94247

github-actions bot added the cla-needed label Feb 19, 2026

fredericoo added 4 commits February 19, 2026 12:07

fix: remove jest types, add node types to hydrogen

128bc5c

ci: fix testing library issues

b5cb332

fix: add missing types pacakges

03474b3

fix: dep

bf11a03

fredericoo commented Feb 19, 2026

View reviewed changes

chore: overly find and replace

8662af6

fredericoo commented Feb 19, 2026

View reviewed changes

turbo.json Outdated Show resolved Hide resolved

feat: parallelise operations in compile template for dist

a5a2a5c

fredericoo commented Feb 19, 2026

View reviewed changes

fredericoo added 3 commits February 19, 2026 15:30

chore: repeated overrides

d3fe927

ci: use SHA versioned action

ade9994

ci: let pnpm version be inferred from package json

6d55ab0

fredericoo marked this pull request as ready for review February 19, 2026 15:52

fredericoo requested a review from a team as a code owner February 19, 2026 15:52

fredericoo requested review from andguy95, frandiox, itsjustriley and kdaviduik February 19, 2026 15:53

kdaviduik reviewed Feb 19, 2026

View reviewed changes

.github/workflows/snapit.yml Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

fredericoo added 2 commits February 19, 2026 18:50

chore: move overrides to pnpm-workspace

5510770

ci: fix snapit workflow

3676e01

kdaviduik approved these changes Feb 23, 2026

View reviewed changes

fredericoo added 2 commits February 23, 2026 11:42

Merge remote-tracking branch 'origin/main' into fb-npm2pnpm

6325846

chore: fmt

802f3df

fredericoo changed the title ~~chore: migrate to pnpm~~ chore: switch package managers to pnpm Feb 23, 2026

fredericoo force-pushed the fb-npm2pnpm branch from b621109 to 802f3df Compare February 23, 2026 15:00

andguy95 approved these changes Feb 23, 2026

View reviewed changes

Comments

Conversation

fredericoo commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Before

After

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kdaviduik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andguy95 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fredericoo commented Feb 18, 2026 •

edited

Loading