Open
Conversation
Member
Huliiiiii
commented
Jan 17, 2026
Huliiiiii
commented
- Closes Support EXPLAIN statement #1036
Huliiiiii
requested review from
Expurple and
tyt2y3
and removed request for
Expurple
Huliiiiii
force-pushed
the
explain
branch
2 times, most recently
from
c8fff9b to
4494564
Compare
Huliiiiii
commented
Jan 19, 2026
src/extension/mysql/explain.rs
Outdated
|
|
||
| /// MySQL-only EXPLAIN table/column or wildcard target. | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct ExplainTable { |
Member
Author
There was a problem hiding this comment.
Maybe this would be better?
pub enum ExplainTable {
Table(..),
WithColumn(..)
WithWildcard(..)
}
Huliiiiii
commented
Jan 19, 2026
| assert_eq!( | ||
| ExplainStatement::new() | ||
| .analyze() | ||
| .verbose(false) |
Member
Author
There was a problem hiding this comment.
option(bool) or option()/option_false()?
Contributor
There was a problem hiding this comment.
I'd prefer option(bool) that matches PG's model 1:1.
Huliiiiii
force-pushed
the
explain
branch
2 times, most recently
from
55e1447 to
aa0a5c2
Compare
Member
Author
|
@tisonkun 方便的话可以看看符不符合需求和review一下。 |
tisonkun
approved these changes
Jan 19, 2026
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Final user-facing result LGTM. I can test it out once a new rc is out.
Huliiiiii
force-pushed
the
explain
branch
2 times, most recently
from
6dcf423 to
3f310aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.