Skip to content

SBND Timing Reconstruction Refactor#637

Open
VCLanNguyen wants to merge 4 commits intodevelopfrom
feature/frame_shift_refactor_v10_14_02
Open

SBND Timing Reconstruction Refactor#637
VCLanNguyen wants to merge 4 commits intodevelopfrom
feature/frame_shift_refactor_v10_14_02

Conversation

@VCLanNguyen
Copy link
Contributor

@VCLanNguyen VCLanNguyen commented Mar 4, 2026

Description

  • Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
  • After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
  • Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
  • The timing correction applied at CAFMakeer is undone.
  • Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45982

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
SBNSoftware/sbndcode#847

This PR needs to be merged together with this group of PRs:

Checklists

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@VCLanNguyen VCLanNguyen changed the title Feature/frame shift refactor v10 14 02 SBND Timing Reconstruction Refactor Mar 4, 2026
@VCLanNguyen VCLanNguyen self-assigned this Mar 4, 2026
@VCLanNguyen VCLanNguyen added breaking change dependent An issue or PR depending on another labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change dependent An issue or PR depending on another

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant