[PULL REQUEST] Updated Regional GQ ASE logic for 2010#202
Open
GregorSchroeder wants to merge 1 commit intomainfrom
Open
[PULL REQUEST] Updated Regional GQ ASE logic for 2010#202GregorSchroeder wants to merge 1 commit intomainfrom
GregorSchroeder wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a divide by zero error in the Regional GQ (Group Quarters) ASE (Age/Sex/Ethnicity) distribution query for the year 2010. The issue was caused by incorrect usage of the RELP field value for 2010 data, which was identified through communication with the Census Bureau that revealed an error in their PUMS documentation.
Changes:
- Corrected RELP field value for 2010 from '14' to '13' to match 2011 and align with actual Census Bureau PUMS data structure
- Consolidated year logic using BETWEEN operator for cleaner, more maintainable code
- Updated TODO comment to accurately reflect the resolution of the divide by zero error
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this pull request. What changes are being made?
Aligns the
@year=2010logic for the[RELPfield with@year=2011.What issues does this pull request address?
closes #157
Additional context
Kind of a cool issue wherein we caught an issue in the PUMS documentation and alerted the Census Bureau.