Conversation
Contributor
Author
|
@Rbb666 帮审下 谢谢 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new peripheral package tm1668 to the RT-Thread Packages repository. The tm1668 is an LED driver chip controlled via a 3-pin interface. The author (龚金华/GKoSon) has previously contributed similar packages to the repository (bt24s, ikunLed, ins5t8025).
Changes:
- Added
peripherals/tm1668/package.jsonwith package metadata pointing to https://github.com/GKoSon/tm1668 - Added
peripherals/tm1668/Kconfigwith configuration options for the package including pin name settings - Updated
peripherals/Kconfigto source the new package's Kconfig file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| peripherals/tm1668/package.json | Defines package metadata including name, description, author, license, and repository URL with only "latest" version |
| peripherals/tm1668/Kconfig | Provides menuconfig options for the package including version selection and pin configuration |
| peripherals/Kconfig | Adds source statement to integrate tm1668 package into the build system |
修改其二
Removed unnecessary header comment from package.json.
Rbb666
approved these changes
Feb 7, 2026
Contributor
Author
|
再看看 合一下 谢谢@Rbb666 |
Rbb666
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本地项目HC32F460验证成功 3PIN驱动TM1668 可以用TM1668做灯板