Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Device Code Flow.
DCF has various limitations compared to traditional applications that rely on traditional OAuth 2 authentication with a Client Secret, and as such some internals had to be adjusted to support managing a DCF token.
Mainly the client assumes only one token is ever used (which is what DCF is designed for) and assigns and overrides the internal app token with the provided user token from DCF.
Currently this allows separation of the 2 designs (DCF/Traditional) by adding specific methods to Client to Login/Start, with DCF use-cases in mind (which should be user devices like phones and TVs or home assistants).
Checklist