Add device parameter to ToCupy operator and to_cupy utility #738
Open
Deshan-5 wants to merge 2 commits intoPyLops:devfrom
Open
Add device parameter to ToCupy operator and to_cupy utility #738Deshan-5 wants to merge 2 commits intoPyLops:devfrom
Deshan-5 wants to merge 2 commits intoPyLops:devfrom
Conversation
Deshan-5
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640.
ToCupy currently hardcodes transfers to device 0, which breaks workflows on multi gpu machines where you need to target a specific device.
This adds a (device: int = 0) parameter to both ToCupy and the underlying to_cupy() utility.
Defaults to 0 so nothing breaks for existing users.
The implementation uses cp.cuda.Device context management, same pattern as to_cupy_conditional() which already handles this correctly.
Added test_ToCupy_device to cover the new parameter.