Skip to content

Add support for Cryogenesis Bloodline node#9517

Merged
LocalIdentity merged 9 commits intoPathOfBuildingCommunity:devfrom
EtherealCarnivore:rename-cryogenesis
Mar 6, 2026
Merged

Add support for Cryogenesis Bloodline node#9517
LocalIdentity merged 9 commits intoPathOfBuildingCommunity:devfrom
EtherealCarnivore:rename-cryogenesis

Conversation

@EtherealCarnivore
Copy link
Contributor

@EtherealCarnivore EtherealCarnivore commented Mar 2, 2026

3.28 renamed the Breachlord Bloodline notable from Otherworldly Appendages to Cryogenesis and replaced the old graft damage reduction stats with two new ones:

  • "If Intelligence is your single highest Attribute, all added Damage is treated as added Lightning Damage"
  • "If Dexterity is your single highest Attribute, all added Damage is treated as added Cold Damage"

Changes:

  • Tree data updated across all 4 variants (standard, alternate, ruthless, ruthless alternate)
  • ModParser: two new stat patterns setting AllAddedDamageAsLightning / AllAddedDamageAsCold flags
  • CalcPerform: IntSingleHighestAttribute / DexSingleHighestAttribute conditions (strict >, no ties)
  • CalcOffence: redirects flat added damage from all types into the target type when the flag is active. Only affects added (flat) damage - weapon and skill base damage stays as-is, matching the "all added Damage" wording. Conversion still works normally on the resulting base values.

Tested by running the full test suite (195/195 pass).

@EtherealCarnivore EtherealCarnivore marked this pull request as draft March 2, 2026 20:37
3.28 replaces the old graft damage reduction stats with:
- Int single highest attribute: all added damage treated as Lightning
- Dex single highest attribute: all added damage treated as Cold

Updated tree data (all 4 variants), added ModParser entries,
single-highest-attribute conditions in CalcPerform, and flat
added damage redirection in CalcOffence.
@EtherealCarnivore EtherealCarnivore changed the title Rename Otherworldly Appendages to Cryogenesis Rename Otherworldly Appendages to Cryogenesis, add new stats Mar 2, 2026
@EtherealCarnivore EtherealCarnivore marked this pull request as ready for review March 2, 2026 21:30
@EtherealCarnivore
Copy link
Contributor Author

Draft -> Ready to review

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Mar 5, 2026
LocalIdentity and others added 8 commits March 6, 2026 06:18
Like ReplaceMod but matches by oldName instead of the new mod's name,
so it can change a mod's identity (e.g. FireMin -> ColdMin) rather
than just updating its value. ModDB moves the mod between name buckets.
ModParser entries now match the actual 3.28 tree text instead of
guessed wording. Handles the "Lighting" typo with a pattern.

CalcOffence uses ConvertMod to redirect added damage mods before the
damage loop so breakdowns show the source properly. Base Elemental
Hit is excluded per the node text.

Added ConvertMod to ModStore/ModList/ModDB - like ReplaceMod but
matches by oldName so it can change a mod's identity.
The old cache had these 3.28 tree lines stored as parse failures
from before the ModParser entries existed. Since the cache uses
exact-case text as the key, the tree's mixed-case text always
hit the stale entry and returned "unsupported" without reaching
the new specialModList patterns.

Replaced 3 individual entries with correct parsed results and
removed 3 concatenated multi-line entries that were never going
to match anyway.
Replaced ConvertMod approach with sum-and-offset: for each non-target
damage type, add a negative mod to cancel the original and a positive
mod on the target type. Both labeled "Cryogenesis Conversion" so the
breakdown popup shows where the redirected damage comes from.

Removed ConvertMod/ConvertModInternal from ModStore/ModList/ModDB
since nothing uses them anymore.
Only the base damage granted via ele hit is not meant to be converted. Mods from gear are meant to work still
The breakdown now shows a note on the mods that are converted that the cryogenesis node is what is changing them
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good now

@LocalIdentity LocalIdentity added the pob2 Label for features that should be ported over to PoB-PoE2 label Mar 6, 2026
@LocalIdentity LocalIdentity merged commit 9855e1e into PathOfBuildingCommunity:dev Mar 6, 2026
2 of 3 checks passed
@LocalIdentity LocalIdentity changed the title Rename Otherworldly Appendages to Cryogenesis, add new stats Add support for Cryogenesis Bloodline node Mar 6, 2026
github-actions bot pushed a commit to PathOfBuildingCommunity/PathOfBuilding-PoE2 that referenced this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants