Hide legacy awakened gems from dropdown#9510
Open
EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Hide legacy awakened gems from dropdown#9510EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Most awakened support gems were discontinued in 3.28. They're now hidden from the gem dropdown unless "Show legacy gems" is checked. Awakened Empower, Enlighten, and Enhance are still shown since they're still obtainable. Existing builds with legacy awakened gems load and calculate fine - this only affects the picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Hides discontinued awakened support gems from the gem dropdown by default. Awakened Empower, Enlighten, and Enhance still show up since they're still obtainable.
Adds a "Show legacy gems" checkbox in Gem Options to bring them back if needed.
How it works
Filters on
plusVersionOf- if a gem has it and isn't one of the three exceptions, it's hidden from the dropdown. No data file changes, no per-gem flags.Existing builds that use legacy awakened gems still load and calculate normally. The gems are saved by ID, so the dropdown filter doesn't affect them.
Changes
GemSelectControl.lua- filter legacy awakened gems inPopulateGemList(),FilterSupport(), and cache invalidation inUpdateSortCache()SkillsTab.lua- new "Show legacy gems" checkbox, saved/loaded with the buildTesting