Ordered xml tags

[Chander-00]

Fixes # .

Description of the problem being solved:

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

[Copilot]

Pull request overview

This PR aims to make build serialization output deterministic by enforcing stable ordering when saving XML (both section order and previously unordered table traversals), which helps reduce noisy diffs and improves reproducibility across runs/environments.

Changes:

• Enforce a fixed save order for build sections and sort various saved key sets (config inputs, calcs inputs, passive spec allocations, item slot names).
• Sort XML attribute emission in xml.ComposeXML for deterministic attribute ordering.
• Extend HeadlessWrapper.lua with JSON-based loading/export helpers and stubs/implementations for compression/UTF-8.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/Modules/Build.lua	Saves build sections in a fixed order for deterministic output
src/HeadlessWrapper.lua	Adds CLI arg preservation, compression functions, UTF-8 stub, and JSON-driven build loading/export behavior
src/Classes/PassiveSpec.lua	Sorts passive allocations/mastery/jewel/override data before saving
src/Classes/ItemsTab.lua	Sorts equipment slot names before saving item sets
src/Classes/ConfigTab.lua	Sorts config input/placeholder keys before saving
src/Classes/CalcsTab.lua	Sorts calcs input keys before saving
runtime/lua/xml.lua	Sorts XML attribute keys when composing XML
jsons/items.json	Adds a build-specific items JSON blob (appears to be debug data)
jsons/passives.json	Adds a build-specific passives JSON blob (appears to be debug data)
.gitignore	Ignores buildcode.txt and main.go

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

composeNode now sorts node.attrib keys before validating they are strings. If a non-string attribute key ever appears, table.sort(sortedKeys) can throw (attempt to compare number with string / invalid order) rather than returning the existing descriptive error message. Consider validating keys (and maybe values) while building sortedKeys, returning the same error string before sorting, or sorting with a comparator that assumes strings only after validation.

[Copilot]

The require override always returns the stub table for lua-utf8, even if a real lua-utf8 module is available in the runtime. This can silently break any code relying on correct UTF-8 semantics (the stub uses byte-based #/string.sub, etc.). Prefer attempting l_require("lua-utf8") first (pcall) and only falling back to the stub when the module can’t be loaded.

[Copilot]

This looks like a large, build-specific JSON blob being added to the repo. If it’s only for local debugging of HeadlessWrapper.lua, it’s better kept out of version control (add to .gitignore) or moved to a small, curated test fixture under spec/TestBuilds/tests with a clear purpose to avoid repo bloat and accidental inclusion of personal/exported data.

[Copilot]

This looks like a large, build-specific JSON blob being added to the repo. If it’s only for local debugging of HeadlessWrapper.lua, it’s better kept out of version control (add to .gitignore) or moved to a small, curated test fixture under spec/TestBuilds/tests with a clear purpose to avoid repo bloat and accidental inclusion of personal/exported data.

[Copilot]

This change alters XML serialization ordering (attributes now sorted). Given xml.ComposeXML is a core utility, it would be good to add a small busted test covering deterministic attribute ordering (and that invalid attrib keys still return an error message rather than throwing), to prevent regressions.

[Copilot]

If only one of the two JSON files opens successfully, the other handle is left open because the code only closes files inside the if itemsFile and passivesFile branch. Consider closing any handle that did open before taking the error path (or open/read each file in its own pcall/helper).

[Copilot]

HeadlessWrapper’s Deflate/Inflate now hard-require the Lua module zlib. This repo already depends on lzip for DEFLATE (e.g. src/UpdateCheck.lua), but does not appear to ship a zlib Lua binding; on environments where zlib isn’t installed this will crash at runtime (and headless mode is used in CI). Consider switching to the existing lzip binding (or pcall(require, ...) fallback) and ideally requiring the module once rather than on every call.

[Copilot]

This file now executes a fairly large JSON-loading/export routine at module top-level when two CLI args are present. That introduces non-trivial side effects in HeadlessWrapper.lua (which is used by CI and potentially as a library) and includes a lot of commented-out debug logging. Consider moving this functionality into a dedicated script/module (or guarding it behind an explicit flag) to keep the wrapper focused on providing the headless environment and helper functions.

[Copilot]

saverOrder duplicates the keys already defined in self.savers during Init. This creates a sync risk: adding/removing a saver requires updates in two places or the section may stop being saved. Consider defining a single ordered list once (used to build self.savers and to iterate here), or deriving the order from self.savers with a stable predefined list constant.

Suggested change

	local saverOrder = {"Config", "Notes", "Party", "Tree", "TreeView", "Items", "Skills", "Calcs", "Import"}
	local saverOrder = {}
	for key in pairs(self.savers) do
	t_insert(saverOrder, key)
	end
	t_sort(saverOrder)