Redirect user to build list menu on initial build load crash#9493
Open
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Redirect user to build list menu on initial build load crash#9493Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Currently if a build crashes on initial load the user will be stuck in the OnError screen. This is especially problematic if the build is set to default load on startup essentially locking the user out of POB. This PR redirect the user to the build list menu if a build crashes on initial load allowing the user to dismiss the error and load a different build.
Paliak
added
enhancement
Contributor
|
Nice work, much elegant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Currently if a build crashes on initial load the user will be stuck in the OnError screen. This is especially problematic if the build is set to default load on startup essentially locking the user out of POB. This PR redirect the user to the build list menu if a build crashes on initial load allowing the user to dismiss the error and load a different build.
The main caveat with the suggested approach is that I'm not sure whether global state won't get wonky. It doesn't appear to from testing.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before video:
before.mp4
After video:
after.mp4