Skip to content

[MIG] web_widget_image_download: Migration to 18.0#3439

Open
Ghostdev9410 wants to merge 45 commits intoOCA:18.0from
Ghostdev9410:18.0-mig-image-download
Open

[MIG] web_widget_image_download: Migration to 18.0#3439
Ghostdev9410 wants to merge 45 commits intoOCA:18.0from
Ghostdev9410:18.0-mig-image-download

Conversation

@Ghostdev9410
Copy link

This PR migrates the web_widget_image_download module to Odoo 18.0.

Major changes:

  • Migration to 18.0: Updated manifest, README links, and metadata to reflect compatibility with the new version.
  • [FIX] Improved Mobile Support:
    • Injected the ui service into the component to detect small screens.
    • Modified the XML template to force the download icon's visibility on touch devices (where hover is not available), ensuring the button is always accessible without needing to click the image first.
  • Coding Standards: All files have been formatted according to the latest OCA standards (Prettier, ESLint, Pylint).

Verified and tested on a clean Odoo 18.0 instance.

@Ghostdev9410 Ghostdev9410 mentioned this pull request Feb 17, 2026
46 tasks
@legalsylvain legalsylvain marked this pull request as draft February 17, 2026 18:12
@legalsylvain
Copy link
Contributor

Please, respect commit history !

@Ghostdev9410 Ghostdev9410 force-pushed the 18.0-mig-image-download branch from 34f2c4b to 354bddc Compare February 17, 2026 18:58
kutyel and others added 26 commits February 17, 2026 20:04
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/zh_CN/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-12.0/web-12.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/es/
Peerapong-Supasompob and others added 18 commits February 17, 2026 20:04
Currently translated at 100.0% (1 of 1 strings)

Translation: web-14.0/web-14.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_image_download/it/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-15.0/web-15.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-15.0/web-15.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_widget_image_download
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_image_download/
@Ghostdev9410 Ghostdev9410 force-pushed the 18.0-mig-image-download branch from 354bddc to d4fd7ab Compare February 17, 2026 19:08
@Ghostdev9410
Copy link
Author

My apologies for the oversight regarding the commit history. As a new contributor to the OCA workflow, I missed the requirement to base the migration on the previous branch.

I have corrected this by resetting the branch and reapplying the migration using "format-patch" to ensure the full history from 17.0 is preserved.

@Ghostdev9410 Ghostdev9410 marked this pull request as ready for review February 17, 2026 19:15
Copy link

@giarve giarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine on runboat

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleting this icon ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me not being showed as deleted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sylvain, good catch! You're absolutely right, I must have accidentally dropped the icon during the branch migration. Thanks for spotting it! I've restored the original file and pushed the fix to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.