disable image push/slack notification for non main branch#638
Merged
Conversation
3d6e487 to
24c9b20
Compare
24c9b20 to
aa16a8b
Compare
rahulait
reviewed
Mar 5, 2026
rahulait
reviewed
Mar 5, 2026
rahulait
reviewed
Mar 5, 2026
rahulait
reviewed
Mar 5, 2026
rahulait
reviewed
Mar 5, 2026
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
aa16a8b to
576df67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1:
If the pipeline (
workflow_dispatch:a manual run from a feature branch) pushes the base and driver images to theghcrrepo, the scheduled pipeline on main will treat that kernel version already published for base and driver image.As a result, it will skip e2e tests and image publish for that kernel version for main branch.
Solution:
For manual runs via workflow_dispatch on a feature branch ( not main):
This will restrict Slack and image pushes to main (e.g. scheduled runs or manual runs from main).
on feature branches, only build and test, no notifications and no pushes.
That keeps scheduled runs on main as the only ones that publish and notify.
issue 2:
file: tests/scripts/findkernelversion.sh :
Script set
KERNEL_FLAVOR="${1}"but usedsuffix="${kernel_flavor}-${DIST}".kernel_flavoris never set, sosuffixbecame-${DIST}(e.g.-ubuntu22.04) instead ofgeneric-ubuntu22.04.When it works:
Artifact dirs happen to match the wrong pattern (e.g. only one flavor, or first match ).
Solution: s
uffix="${KERNEL_FLAVOR}-${DIST}"Issue 3:
Script expected artifact files under
./matrix-values-artifacts/${artifact_name}/matrix_values_${dist}_${kernel}.jsonWith
when only one artifact matches it is extracted flat into
./matrix-values-artifacts/(noartifact-namesubdir), so the file is at./matrix-values-artifacts/matrix_values_${dist}_${kernel}.json.When it works:
Multiple matrix artifacts: download creates one subdir per artifact.
Solution: After checking the nested path, check the flat path:
./matrix-values-artifacts/matrix_values_${dist}_${kernel}.json, and use whichever exists so both single-artifact and multi-artifact work.passed pipeline:
https://github.com/NVIDIA/gpu-driver-container/actions/runs/22710560690/job/65852046464