Conversation
|
Caution MetaMask internal reviewing guidelines:
|
bcc987a to
330f17c
Compare
| # Generate Changelog and Test Plan | ||
| echo "Generating changelog via auto-changelog.." | ||
| npx @metamask/auto-changelog@4.1.0 update --rc --repo "${GITHUB_REPOSITORY_URL}" --currentVersion "${new_version}" --autoCategorize | ||
| yarn auto-changelog update --rc --repo "https://github.com/MetaMask/metamask-extension" --currentVersion "${new_version}" --autoCategorize --useChangelogEntry --useShortPrLink |
There was a problem hiding this comment.
Bug: Hardcoded URL Breaks Multi-Platform Changelog
The auto-changelog command now uses a hardcoded repository URL (https://github.com/MetaMask/metamask-extension) instead of the dynamic GITHUB_REPOSITORY_URL environment variable. This breaks the script's intended multi-platform support, causing changelogs for other repositories (e.g., mobile) to incorrectly reference the extension repository.
| # Generate Changelog and Test Plan | ||
| echo "Generating changelog via auto-changelog.." | ||
| npx @metamask/auto-changelog@4.1.0 update --rc --repo "${GITHUB_REPOSITORY_URL}" --currentVersion "${new_version}" --autoCategorize | ||
| yarn auto-changelog update --rc --repo "https://github.com/MetaMask/metamask-extension" --currentVersion "${new_version}" --autoCategorize --useChangelogEntry --useShortPrLink |
There was a problem hiding this comment.
The repo shall not be hardcoded to "https://github.com/MetaMask/metamask-extension". It can also be "https://github.com/MetaMask/metamask-mobile".
There was a problem hiding this comment.
Oh, yes, that just had to be done so it could run in metamask-extension-test-workflow2
No description provided.