Open
Conversation
Collaborator
MarcelGeo
commented
Feb 16, 2026
- this file paths will be ignored during files extensions and mime type checks
- this file paths will be ignored during files extensions and mime type checks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an upload file-path whitelist intended to bypass forbidden extension and MIME type checks for specific, configured paths.
Changes:
- Introduces
Configuration.UPLOAD_FILES_WHITELISTin sync configuration. - Adds
check_skip_validation()and integrates it intois_supported_extension()andis_supported_type(). - Adds tests covering whitelist behavior (extension + intended MIME-type skip).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
server/mergin/sync/config.py |
Adds UPLOAD_FILES_WHITELIST configuration option. |
server/mergin/sync/utils.py |
Implements whitelist check and uses it to bypass extension/MIME validation. |
server/mergin/tests/test_utils.py |
Adds unit tests for whitelist behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 22343554432Details
💛 - Coveralls |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
varmar05
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.