Implement mkl_random.interfaces and update mkl_random#92
Open
ndgrigorian wants to merge 5 commits intomasterfrom
Open
Implement mkl_random.interfaces and update mkl_random#92ndgrigorian wants to merge 5 commits intomasterfrom
mkl_random.interfaces and update mkl_random#92ndgrigorian wants to merge 5 commits intomasterfrom
Conversation
Slips in changes updating get_state, set_state, and multivariate_normal to align with recent numpy changes
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
ndgrigorian
changed the title
mkl_random.interfaces and update mk_randommkl_random.interfaces and update mkl_random
now ignore irrelevant RuntimeWarnings and align with the test in NumPy's test suite
cleans up visual indentation and various linter/style mistakes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
mkl_random.interfacesand an interfacenumpy_random, aligning with the approach inmkl_fftto create drop-in replacementsIn adding this,
mkl_randommain namespace was updated as follows_MKLRandomStateMKLRandomState, which also implements all functionality exclusive tomkl_random(this way, numpy interface does not expose such functionality asmultinormal_cholesky)RandomStatewhich effectively aliasesMKLRandomStatewith a deprecation warning (as it will be removed from the namespace in a later release)get_state,set_state, andmultivariate_normalto align with changes in NumPy (especially the addition of keyword arguments inget_stateandmultivariate_normal)