Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in patchFhirStore.js#4245

Open
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-patch-store
Open

fix(healthcare): set responseType to JSON instead of Buffer in patchFhirStore.js#4245
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-patch-store

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Mar 3, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal requested review from a team as code owners March 3, 2026 23:39
@angelcaamal angelcaamal added api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples. labels Mar 3, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the patchFhirStore.js sample by ensuring that API responses are correctly interpreted as JSON, preventing potential data parsing errors. It also significantly improves the user experience by introducing comprehensive error handling and logging the full API response, making it easier to diagnose issues and confirm successful operations.

Highlights

  • API Client Configuration: The Google API client for the Healthcare API has been configured to explicitly expect JSON as the response type, resolving potential issues with response parsing.
  • Error Handling: Robust error handling has been added around the patch operation for FHIR stores, catching and logging any exceptions that occur during the API call.
  • Response Logging: The successful response data from the FHIR store patch operation is now logged to the console, providing clearer feedback on the outcome of the API call.
Changelog
  • healthcare/fhir/patchFhirStore.js
    • Set the responseType for the Google API client to 'json'.
    • Wrapped the healthcare.projects.locations.datasets.fhirStores.patch call in a try-catch block for error handling.
    • Added logging for the successful response data (response.data).
    • Implemented error logging to display error.message or the full error object if the patch operation fails.
Activity
  • The author has provided a checklist indicating adherence to contribution guidelines, testing, and linting standards, with several items marked as complete.
  • The author has requested that the PR be merged once approved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue in patchFhirStore.js by setting the responseType to json, which ensures the API response is correctly handled as a JSON object. The addition of a try...catch block for error handling is a good improvement for robustness. I've added one comment to suggest an improvement to the error logging to provide more detailed diagnostic information. It would also be beneficial to apply similar error handling to other samples in this directory for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant