Skip to content

log exceptions instead of printing them in starrs.py #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tallen42 merged 2 commits into from
Mar 1, 2026
Merged

log exceptions instead of printing them in starrs.py #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbab28a
log exceptions instead of printing them in starrs.py
WillNilges Mar 1, 2026
525a01f
placate robots
WillNilges Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions proxstar/starrs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
import logging

logging.basicConfig(format='%(asctime)s %(levelname)s %(message)s', level=logging.INFO)


def get_next_ip(starrs, range_name):
c = starrs.cursor()
try:
Expand All @@ -7,7 +12,7 @@ def get_next_ip(starrs, range_name):
results = c.fetchall()
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
starrs.rollback()
finally:
c.close()
Expand All @@ -23,7 +28,7 @@ def get_ip_for_mac(starrs, mac):
results = c.fetchall()
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
starrs.rollback()
finally:
c.close()
Expand All @@ -41,7 +46,7 @@ def renew_ip(starrs, addr):
results = c.fetchall()
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
starrs.rollback()
finally:
c.close()
Expand Down Expand Up @@ -79,7 +84,7 @@ def check_hostname(starrs, hostname):
available = False
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
valid = False
available = False
starrs.rollback()
Expand All @@ -104,7 +109,7 @@ def register_starrs(starrs, name, owner, mac, addr):
c.callproc('api.modify_system', (name, 'comment', f'Owned by {owner}'))
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
starrs.rollback()
finally:
c.close()
Expand All @@ -120,7 +125,7 @@ def delete_starrs(starrs, name):
results = c.fetchall()
c.execute('COMMIT')
except Exception as e:
print(e)
logging.exception(e)
starrs.rollback()
finally:
c.close()
Expand Down