London | 26-ITP-January | Karla Grajales | Sprint 1 | coursework/sprint-1#910
London | 26-ITP-January | Karla Grajales | Sprint 1 | coursework/sprint-1#910Grajales-K wants to merge 32 commits intoCodeYourFuture:mainfrom
Conversation
…d using and alert.
… methods like substring and padStart to add and take part or the string
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @Theoreoluwa, thank you very much for your time reviewing my code. I have made the suggested changes, and I hope it is now more suitable and readable. Thanks! |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Theoreoluwa
left a comment
There was a problem hiding this comment.
Well done, you've done all required so far. You just need to sort out the newly committed file and folder that's not meant for this sprint before I get your PR approved.
|
Hi @Theoreoluwa, please, if you have a chance, can you kindly review my PR? Thank you |
|
I’ll get that done for you tonight. Had a busy schedule for the past week. |
|
@Theoreoluwa, no pressure. When you have time, thank you for your time. |
Theoreoluwa
left a comment
There was a problem hiding this comment.
Good work, Karla. You utilised the feedback given to improve on your task, which is a very good trait. Well done and keep going!
Learners, PR Template
Self checklist
Changelist
This project is about starting to learn how to use methods in JS, and using the console on the browser, at some point, my branch remotely and locally lost the connection, so I ran from my terminal
git branch --unset-upstreamand thengit push -u origin coursework/sprint-1to link the branches.Questions
Do you have any recommendations for learning how to use Git more deeply, especially when we want to go back in history and keep only a specific part in the head of my branch?
Basically, a surgery choosing a specific part to bring back from historical commits.