WestMidlands| SDC NOV 2025 | Sara Tahir | Sprint 2 |Improve with precomputing#120
Open
SaraTahir28 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
WestMidlands| SDC NOV 2025 | Sara Tahir | Sprint 2 |Improve with precomputing#120SaraTahir28 wants to merge 2 commits intoCodeYourFuture:mainfrom
SaraTahir28 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
SaraTahir28
added
the
Needs Review
cjyuan
reviewed
Feb 26, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you use complexity to explain why your implementations are better than the originals?
There was a problem hiding this comment.
The indentation and spacing of the code in this file is a bit off. Can you improve the formatting of the code?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Common prefixes
In the original implementation we compared every pair of strings, which is O(n²). By sorting the list first, strings with similar prefixes become adjacent, so we only need to compare neighbouring pairs. This reduces the complexity to O(n log n)
Count Letters
I have Precomputed lowercase and uppercase character sets to avoid repeated full‑string scans.
This reduces count_letters from O(n²) to O(n).
Questions
I have no Questions. Thankyou.