[BUG FIX] Add NULL check for fopen return value in process_hex()#2157
Open
Anayo-Anyafulu wants to merge 1 commit intoCCExtractor:masterfrom
Open
[BUG FIX] Add NULL check for fopen return value in process_hex()#2157Anayo-Anyafulu wants to merge 1 commit intoCCExtractor:masterfrom
Anayo-Anyafulu wants to merge 1 commit intoCCExtractor:masterfrom
Conversation
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit c3c5d9c...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 8de778a...:
Congratulations: Merging this PR would fix the following tests:
All tests passed completely. Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In process_hex() in src/lib_ccx/general_loop.c, fopen() was called without checking if the returned FILE pointer is NULL. If the file cannot be opened, the subsequent fgets() call would crash with a NULL pointer dereference.
Changes
Testing
Manually verified the fix compiles cleanly.