-
Notifications
You must be signed in to change notification settings - Fork 315
Return default value when entity ttl is retrieved with entity cache enabled set to false #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronburtle
wants to merge
15
commits into
main
Choose a base branch
from
dev/aaronburtle/AllowRequestWhenRuntimeCacheExistsAndEntityCacheDoesNot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−34
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e57417e
entity fall back for cache
aaronburtle e5a7594
regression test for fix
aaronburtle 5dc4506
Apply suggestion from @Copilot
aaronburtle fdac9bf
Merge branch 'main' into dev/aaronburtle/AllowRequestWhenRuntimeCache…
aaronburtle 8479107
Merge branch 'dev/aaronburtle/AllowRequestWhenRuntimeCacheExistsAndEn…
aaronburtle e8ccbf8
use default value when available
aaronburtle 5a7b9df
Merge branch 'main' into dev/aaronburtle/AllowRequestWhenRuntimeCache…
aaronburtle 3bea2cb
change test sig for flakiness
aaronburtle fe10a4f
Merge branch 'main' into dev/aaronburtle/AllowRequestWhenRuntimeCache…
aaronburtle 8b05eeb
return null when cache not enabled
aaronburtle b4a4dff
Merge branch 'dev/aaronburtle/AllowRequestWhenRuntimeCacheExistsAndEn…
aaronburtle 067cf22
Merge branch 'main' into dev/aaronburtle/AllowRequestWhenRuntimeCache…
aaronburtle bdd1990
return global default when non exists
aaronburtle 7836a4b
Apply suggestions from code review
Aniruddh25 2da38ec
Merge branch 'main' into dev/aaronburtle/AllowRequestWhenRuntimeCache…
Aniruddh25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.