Antalya 25.8 backports of #88490 and #89999#1475
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6890496805
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| std::map<Int64, PreparedSetsCachePtr::weak_type> mutation_prepared_sets_cache; | ||
| PlainLightweightUpdatesSync lightweight_updates_sync; | ||
|
|
||
| const bool support_transaction; |
There was a problem hiding this comment.
support_transaction is now a const bool computed only in the constructor, but MergeTree settings can change at runtime (ALTER ... MODIFY SETTING disk/storage_policy handled in MergeTreeData::changeSettings), which changes the table's effective disks after construction. With this cache, supportsTransactions() can return a stale value, so a table may keep allowing transactional writes after switching to a non-append-capable object-storage layout (or keep rejecting them after switching back), causing behavior that no longer matches actual disk capabilities.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good point, but don't want to fix it in backport.
ianton-ru
force-pushed
the
backport/antalya-25.8/89999
branch
2 times, most recently
from
e83e65e to
af3fc30
Compare
…tion-for-non-append-supporting-disks Not support transaction for tables with disks which do not support writing with append. Signed-off-by: Anton Ivashkin <ianton@live.com>
Check if encrypted disks support writing with append Signed-off-by: Anton Ivashkin <ianton@live.com>
ianton-ru
force-pushed
the
backport/antalya-25.8/89999
branch
from
af3fc30 to
7877582
Compare
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
For MergeTree tables using object storage which do not support writing with append, it will not support transactions. (ClickHouse#88490 by @tuanpach)
Check if encrypted disks support writing with append (ClickHouse#89999 by @tuanpach)
Closes ClickHouse#84669
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: