Skip to content

[PWGHF] Protect daughter index access in selectEvent to prevent segmentation faults#2281

Merged
alcaliva merged 2 commits intoAliceO2Group:masterfrom
alcaliva:master
Feb 26, 2026
Merged

[PWGHF] Protect daughter index access in selectEvent to prevent segmentation faults#2281
alcaliva merged 2 commits intoAliceO2Group:masterfrom
alcaliva:master

Conversation

@alcaliva
Copy link
Collaborator

No description provided.

@alcaliva alcaliva requested a review from a team as a code owner February 25, 2026 17:18
@github-actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alcaliva alcaliva enabled auto-merge (squash) February 25, 2026 17:19
@alcaliva
Copy link
Collaborator Author

Hi @ktf,

the build fails with the following message.
Do you perhaps have any clue of what is going wrong here?
Thanks for your help!

Alberto

========================================================================================

Git command for package 'Eigen3' failed.
Command: git clone --bare https://gitlab.com/libeigen/eigen.git /build/nomad/alloc/d26ec214-7bf3-2c16-0abe-db1b12c2dd0b/ci/local/o2dpg-sim-tests/sw/MIRROR/eigen3 --filter=tree:0
In directory: .
Exit code: 128
Git command for package 'Openloops' failed.
Command: git clone --bare https://gitlab.com/openloops/OpenLoops.git /build/nomad/alloc/d26ec214-7bf3-2c16-0abe-db1b12c2dd0b/ci/local/o2dpg-sim-tests/sw/MIRROR/openloops --filter=tree:0
In directory: .
Exit code: 128
Git command for package 'SHERPA' failed.
Command: git clone --bare https://gitlab.com/sherpa-team/sherpa.git /build/nomad/alloc/d26ec214-7bf3-2c16-0abe-db1b12c2dd0b/ci/local/o2dpg-sim-tests/sw/MIRROR/sherpa --filter=tree:0
In directory: .
Exit code: 128
Git command for package 'YODA' failed.
Command: git clone --bare https://gitlab.com/hepcedar/yoda.git /build/nomad/alloc/d26ec214-7bf3-2c16-0abe-db1b12c2dd0b/ci/local/o2dpg-sim-tests/sw/MIRROR/yoda --filter=tree:0
In directory: .
Exit code: 128
Git command for package 'Rivet' failed.
Command: git clone --bare https://gitlab.com/hepcedar/rivet.git /build/nomad/alloc/d26ec214-7bf3-2c16-0abe-db1b12c2dd0b/ci/local/o2dpg-sim-tests/sw/MIRROR/rivet --filter=tree:0
In directory: .
Exit code: 128

continue;
}

// Swap order
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alcaliva ! Thanks for the update! I don't have any major comment. Just for my understanding though, does it really happens to have unsorted daughter indices? If I am not mistaken, the first and last daughter indices correspond to the first and last daughter index in the decay tree

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanopolitano,
honestly, I don't know. I've seen this kind of protection in other codes so I decided to include it also here.
If it doesn't happen, it should be harmless.

@alcaliva alcaliva merged commit 8a4a641 into AliceO2Group:master Feb 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants