From 1a8613606ed401b224d9845f97e8a07e4b5c5821 Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Tue, 3 Mar 2026 17:20:01 +0100 Subject: [PATCH 1/5] fix font-size issue of disabled link without given URL --- src/components/Link/link.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/Link/link.scss b/src/components/Link/link.scss index d07676b68..b5b0d9fb9 100644 --- a/src/components/Link/link.scss +++ b/src/components/Link/link.scss @@ -2,8 +2,11 @@ @include link.link; .#{$prefix}--link { - font-size: 1em; - line-height: inherit; + &, + &:hover { + font-size: 1em; + line-height: inherit; + } &:focus { outline: none; From 1b7d1a25ec87e14277edf96f774bfc2ff19931ca Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 4 Mar 2026 11:51:35 +0100 Subject: [PATCH 2/5] add story for Link --- src/components/Link/Link.stories.tsx | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 src/components/Link/Link.stories.tsx diff --git a/src/components/Link/Link.stories.tsx b/src/components/Link/Link.stories.tsx new file mode 100644 index 000000000..5c5e04629 --- /dev/null +++ b/src/components/Link/Link.stories.tsx @@ -0,0 +1,30 @@ +import React from "react"; +import { Meta, StoryFn } from "@storybook/react"; + +import { Link } from "../../../index"; + +export default { + title: "Components/Link", + component: Link, + argTypes: { + target: { + control: "select", + options: ["_self", "_blank", "_parent", "_top"], + }, + }, +} as Meta; + +const Template: StoryFn = (args) => ; + +export const Default = Template.bind({}); +Default.args = { + children: "Example link", + href: "https://example.com/", +}; + +export const Disabled = Template.bind({}); +Disabled.args = { + children: "Disabled link", + href: "https://example.com/", + disabled: true, +}; From 5b26d1b07298d61d5ea87c98772eed6188bdf7a3 Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 4 Mar 2026 11:51:58 +0100 Subject: [PATCH 3/5] fix styles for Link sizes --- src/components/Link/link.scss | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/components/Link/link.scss b/src/components/Link/link.scss index b5b0d9fb9..3dbd9729f 100644 --- a/src/components/Link/link.scss +++ b/src/components/Link/link.scss @@ -4,10 +4,24 @@ .#{$prefix}--link { &, &:hover { + // default case: use font size from context font-size: 1em; line-height: inherit; } + &.#{$prefix}--link--sm { + font-size: $eccgui-size-typo-caption; + line-height: $eccgui-size-typo-caption-lineheight; + } + &.#{$prefix}--link--md { + font-size: $eccgui-size-typo-text; + line-height: $eccgui-size-typo-text-lineheight; + } + &.#{$prefix}--link--lg { + font-size: $eccgui-size-typo-subtitle; + line-height: $eccgui-size-typo-subtitle-lineheight; + } + &:focus { outline: none; outline-offset: 0; From 50fcaaaadf67ea0666dc7429079e57cb6c54141f Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 4 Mar 2026 13:13:45 +0100 Subject: [PATCH 4/5] stabilize Link font size on hover --- src/components/Link/link.scss | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/components/Link/link.scss b/src/components/Link/link.scss index 3dbd9729f..c5348af49 100644 --- a/src/components/Link/link.scss +++ b/src/components/Link/link.scss @@ -5,21 +5,30 @@ &, &:hover { // default case: use font size from context - font-size: 1em; + font-size: inherit; line-height: inherit; } &.#{$prefix}--link--sm { - font-size: $eccgui-size-typo-caption; - line-height: $eccgui-size-typo-caption-lineheight; + &, + &:hover { + font-size: $eccgui-size-typo-caption; + line-height: $eccgui-size-typo-caption-lineheight; + } } &.#{$prefix}--link--md { - font-size: $eccgui-size-typo-text; - line-height: $eccgui-size-typo-text-lineheight; + &, + &:hover { + font-size: $eccgui-size-typo-text; + line-height: $eccgui-size-typo-text-lineheight; + } } &.#{$prefix}--link--lg { - font-size: $eccgui-size-typo-subtitle; - line-height: $eccgui-size-typo-subtitle-lineheight; + &, + &:hover { + font-size: $eccgui-size-typo-subtitle; + line-height: $eccgui-size-typo-subtitle-lineheight; + } } &:focus { From 562d5e12e15e5d4709d92a576cae97c53755e0ba Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 4 Mar 2026 13:16:54 +0100 Subject: [PATCH 5/5] update changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 628cb853e..fac14b7aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p - take Markdown rendering into account before testing the maximum preview length - `` - header-menu items are vertically centered now +- `` + - stabilize font size for on hover state + - use correct font sizes when `size` property is set - `Typography` - adjust displaying fallback symbols in different browsers